From: Shuah Khan <shuahkh@osg.samsung.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: mikey@neuling.org, anton@samba.org
Subject: Re: [PATCH V2 12/12] selftests, powerpc: Add thread based stress test for DSCR sysfs interfaces
Date: Tue, 13 Jan 2015 08:24:47 -0700 [thread overview]
Message-ID: <54B538BF.5040803@osg.samsung.com> (raw)
In-Reply-To: <1421144560-15901-13-git-send-email-khandual@linux.vnet.ibm.com>
On 01/13/2015 03:22 AM, Anshuman Khandual wrote:
> This patch adds a test to update the system wide DSCR value repeatedly
> and then verifies that any thread on any given CPU on the system must
> be able to see the same DSCR value whether its is being read through
> the problem state based SPR or the privilege state based SPR.
>
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> ---
> tools/testing/selftests/powerpc/dscr/Makefile | 2 +-
> .../powerpc/dscr/dscr_sysfs_thread_test.c | 114 +++++++++++++++++++++
> 2 files changed, 115 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/powerpc/dscr/dscr_sysfs_thread_test.c
>
> diff --git a/tools/testing/selftests/powerpc/dscr/Makefile b/tools/testing/selftests/powerpc/dscr/Makefile
> index fada526..834ef88 100644
> --- a/tools/testing/selftests/powerpc/dscr/Makefile
> +++ b/tools/testing/selftests/powerpc/dscr/Makefile
> @@ -1,6 +1,6 @@
> PROGS := dscr_default_test dscr_explicit_test dscr_user_test \
> dscr_inherit_test dscr_inherit_exec_test \
> - dscr_sysfs_test
> + dscr_sysfs_test dscr_sysfs_thread_test
>
> CFLAGS := $(CFLAGS) -lpthread
>
> diff --git a/tools/testing/selftests/powerpc/dscr/dscr_sysfs_thread_test.c b/tools/testing/selftests/powerpc/dscr/dscr_sysfs_thread_test.c
> new file mode 100644
> index 0000000..95a4304
> --- /dev/null
> +++ b/tools/testing/selftests/powerpc/dscr/dscr_sysfs_thread_test.c
> @@ -0,0 +1,114 @@
> +/*
> + * POWER Data Stream Control Register (DSCR) sysfs thread test
> + *
> + * This test updates the system wide DSCR default value through
> + * sysfs interface which should then update all the CPU specific
> + * DSCR default values which must also be then visible to threads
> + * executing on individual CPUs on the system.
> + *
> + * Copyright (C) 2015 Anshuman Khandual <khandual@linux.vnet.ibm.com>, IBM
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */
> +#define _GNU_SOURCE
> +#include "dscr.h"
> +
> +static pthread_mutex_t lock; /* Pthread lock */
> +static cpu_set_t cpuset; /* Thread cpu set */
> +static int target; /* Thread target cpu */
> +static unsigned long *result; /* Thread exit status array */
> +
> +static void *test_thread_dscr(void *in)
> +{
> + unsigned long cur_dscr, cur_dscr_usr;
> + unsigned long val = (unsigned long)in;
> +
> + pthread_mutex_lock(&lock);
> + target++;
> + if (target == sysconf(_SC_NPROCESSORS_ONLN))
> + target = 0;
> + CPU_ZERO(&cpuset);
> + CPU_SET(target, &cpuset);
> +
> + if (sched_setaffinity(0, sizeof(cpuset), &cpuset)) {
> + perror("sched_settarget_cpu() failed\n");
> + pthread_mutex_unlock(&lock);
> + result[target] = 1;
> + pthread_exit(&result[target]);
> + }
> + pthread_mutex_unlock(&lock);
> +
> + cur_dscr = get_dscr();
> + cur_dscr_usr = get_dscr_usr();
> +
> + if (val != cur_dscr) {
> + printf("[cpu %d] Kernel DSCR should be %ld but is %ld\n",
> + sched_getcpu(), val, cur_dscr);
> + result[target] = 1;
> + pthread_exit(&result[target]);
> + }
> +
> + if (val != cur_dscr_usr) {
> + printf("[cpu %d] User DSCR should be %ld but is %ld\n",
> + sched_getcpu(), val, cur_dscr_usr);
> + result[target] = 1;
> + pthread_exit(&result[target]);
> + }
> + result[target] = 0;
> + pthread_exit(&result[target]);
> +}
> +
> +static int check_cpu_dscr_thread(unsigned long val)
> +{
> + pthread_t threads[sysconf(_SC_NPROCESSORS_ONLN)];
> + unsigned long *status[sysconf(_SC_NPROCESSORS_ONLN)];
> + unsigned long i;
> +
> + for (i = 0; i < sysconf(_SC_NPROCESSORS_ONLN); i++) {
> + if (pthread_create(&threads[i], NULL,
> + test_thread_dscr, (void *)val)) {
> + perror("pthread_create() failed\n");
> + return 1;
> + }
> + }
> +
> + for (i = 0; i < sysconf(_SC_NPROCESSORS_ONLN); i++) {
> + if (pthread_join(threads[i], (void **)&(status[i]))) {
> + perror("pthread_join() failed\n");
> + return 1;
> + }
> +
> + if (*status[i]) {
> + printf(" %ldth thread join failed with %ld\n",
> + i, *status[i]);
> + return 1;
> + }
> + }
> + return 0;
> +}
> +
> +int test_body(void)
> +{
> + int i, j;
> +
> + result = malloc(sizeof(unsigned long) * sysconf(_SC_NPROCESSORS_ONLN));
> + pthread_mutex_init(&lock, NULL);
> + target = 0;
> + for (i = 0; i < COUNT; i++) {
> + for (j = 0; j < DSCR_MAX; j++) {
> + set_default_dscr(j);
> + if (check_cpu_dscr_thread(j))
> + return 1;
> + }
> + }
> + free(result);
> + return 0;
> +}
> +
> +int main(int argc, char *argv[])
> +{
> + return test_harness(test_body, "dscr_sysfs_thread_test");
> +}
>
Could you please add a .gitignore for powerpc targets as we
discussed earlier. It can be separate patch.
Also, I would like to see the test results reports using
kselftest.h - it can be separate patch in the interest of
getting tests in.
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
Please take this through powerpc maintainer git.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-01-13 15:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 10:22 [PATCH V2 00/12] POWER DSCR fixes, improvements, docs and tests Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 01/12] powerpc: Fix handling of DSCR related facility unavailable exception Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 02/12] powerpc, process: Remove the unused extern dscr_default Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 03/12] powerpc, offset: Change PACA_DSCR to PACA_DSCR_DEFAULT Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 04/12] powerpc, dscr: Added some in-code documentation Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 05/12] documentation, powerpc: Add documentation for DSCR support Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 06/12] selftests, powerpc: Add test for system wide DSCR default Anshuman Khandual
2015-01-13 15:22 ` Shuah Khan
2015-01-13 23:44 ` Michael Ellerman
2015-01-20 21:40 ` Dave Jones
2015-01-21 6:51 ` Michael Ellerman
2015-03-27 12:01 ` [V2, " Michael Ellerman
2015-04-09 10:31 ` Anshuman Khandual
2015-04-09 12:38 ` Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 07/12] selftests, powerpc: Add test for explicitly changing DSCR value Anshuman Khandual
2015-01-13 15:23 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 08/12] selftests, powerpc: Add test for DSCR SPR numbers Anshuman Khandual
2015-01-13 15:23 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 09/12] selftests, powerpc: Add test for DSCR value inheritence across fork Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 10/12] selftests, powerpc: Add test for DSCR inheritence across fork & exec Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 11/12] selftests, powerpc: Add test for all DSCR sysfs interfaces Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 12/12] selftests, powerpc: Add thread based stress test for " Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan [this message]
2015-02-04 8:21 ` [PATCH V2 00/12] POWER DSCR fixes, improvements, docs and tests Anshuman Khandual
2015-02-04 8:36 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B538BF.5040803@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=anton@samba.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).