From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [1/2] powerpc/powernv: new function to access OPAL msglog
Date: Tue, 9 Feb 2016 16:29:10 +1100 [thread overview]
Message-ID: <56B97926.1090304@au1.ibm.com> (raw)
In-Reply-To: <20160208113149.F33D1140B99@ozlabs.org>
On 08/02/16 22:31, Michael Ellerman wrote:
> Pulling the memcons out of the bin_attr here is not all that nice. This routine
> should really stand on its own without reference to the bin_attr. In theory I
> might want to disable building sysfs but still have this routine available.
Yeah it's a bit ugly, though does disabling sysfs actually break it? I
can separate it out anyway - there's no reason for the memcons to be
tied to the sysfs entry.
> It's also a bit fishy if it's called before the bin_attr is initialised or when
> the memcons initialisation fails. In both cases it should be OK, because the
> structs in question are static and so the private pointer will be NULL, but
> that's a bit fragile.
>
> I think the solution is simply to create a:
>
> static struct memcons *opal_memcons;
>
> And use that in opal_msglog_copy() and so on.
Will respin.
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2016-02-09 5:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 6:50 [PATCH 1/2] powerpc/powernv: new function to access OPAL msglog Andrew Donnellan
2016-01-20 6:50 ` [PATCH 2/2] powerpc/xmon: add command to dump " Andrew Donnellan
2016-02-08 11:31 ` [1/2] powerpc/powernv: new function to access " Michael Ellerman
2016-02-09 5:29 ` Andrew Donnellan [this message]
2016-02-09 10:20 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B97926.1090304@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).