From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.com>,
"Tobias Klauser" <tklauser@distanz.ch>,
"Nicolas Ferre" <nicolas.ferre@atmel.com>,
"Sonic Zhang" <sonic.zhang@analog.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Sylvain Lemieux" <slemieux.tyco@gmail.com>,
"Andy Gross" <andy.gross@linaro.org>,
"David Brown" <david.brown@linaro.org>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Barry Song" <baohua@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Tony Prisk" <linux@prisktech.co.nz>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
nios2-dev@lists.rocketboards.org,
adi-buildroot-devel@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>
Subject: Re: [RFT PATCH 1/2] serial: Fix console setup section mismatch
Date: Tue, 31 May 2016 16:34:47 +0200 [thread overview]
Message-ID: <574DA107.8050002@samsung.com> (raw)
In-Reply-To: <20160531142142.GX19428@n2100.arm.linux.org.uk>
On 05/31/2016 04:21 PM, Russell King - ARM Linux wrote:
> On Tue, May 31, 2016 at 04:19:31PM +0200, Krzysztof Kozlowski wrote:
>> Remove __init annotation from all of console->setup implementations
>> because:
>> 1. The pointer to it is stored in a struct console which is not
>> marked with __initdata.
>> 2. It is referenced by register_console() from kernel which is not
>> marked with __init.
>
> However, many of these drivers, the console can only be used when the
> driver is built-in, and register_console() is only called early in
> initialisation.
Indeed so maybe the word "fix" in commit subject is not proper because
there might be no error at all. My point is that current solution is a
little bit non-obvious and an error might happen. If we were sure that
register_console() is called only from other __init functions, then it
should be made also __init.
Best regards,
Krzysztof
prev parent reply other threads:[~2016-05-31 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 14:19 [RFT PATCH 1/2] serial: Fix console setup section mismatch Krzysztof Kozlowski
2016-05-31 14:19 ` [RFT PATCH 2/2] serial: pnx8xxx: Fix coding style Krzysztof Kozlowski
2016-05-31 14:21 ` [RFT PATCH 1/2] serial: Fix console setup section mismatch Russell King - ARM Linux
2016-05-31 14:34 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574DA107.8050002@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andy.gross@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=baohua@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@prisktech.co.nz \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=macro@linux-mips.org \
--cc=michal.simek@xilinx.com \
--cc=mpe@ellerman.id.au \
--cc=nicolas.ferre@atmel.com \
--cc=nios2-dev@lists.rocketboards.org \
--cc=paulus@samba.org \
--cc=slemieux.tyco@gmail.com \
--cc=sonic.zhang@analog.com \
--cc=soren.brinkmann@xilinx.com \
--cc=sparclinux@vger.kernel.org \
--cc=tklauser@distanz.ch \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).