From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Horia Geanta <horia.geanta@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] Additional fixes on Talitos driver
Date: Wed, 12 Jun 2019 07:52:13 +0200 [thread overview]
Message-ID: <58787543-76d3-e0db-9517-ccd0f6494d85@c-s.fr> (raw)
In-Reply-To: <VI1PR0402MB3485AD965F36709F27EFB72698ED0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
Le 11/06/2019 à 18:30, Horia Geanta a écrit :
> On 6/11/2019 6:40 PM, Christophe Leroy wrote:
>>
>>
>> Le 11/06/2019 à 17:37, Horia Geanta a écrit :
>>> On 6/11/2019 5:39 PM, Christophe Leroy wrote:
>>>> This series is the last set of fixes for the Talitos driver.
>>>>
>>>> We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and
>>>> SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS:
>>>>
>>> I am getting below failures on a sec 3.3.2 (p1020rdb) for hmac(sha384) and
>>> hmac(sha512):
>>
>> Is that new with this series or did you already have it before ?
>>
> Looks like this happens with or without this series.
Found the issue, that's in
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b8fbdc2bc4e71b62646031d5df5f08aafe15d5ad
CONFIG_CRYPTO_DEV_TALITOS_SEC2 should be CONFIG_CRYPTO_DEV_TALITOS2 instead.
Just sent a patch to fix it.
Thanks
Christophe
>
> I haven't checked the state of this driver for quite some time.
> Since I've noticed increased activity, I thought it would be worth
> actually testing the changes.
>
> Are changes in patch 2/4 ("crypto: talitos - fix hash on SEC1.")
> strictly for sec 1.x or they affect all revisions?
>
>> What do you mean by "fuzz testing" enabled ? Is that
>> CONFIG_CRYPTO_MANAGER_EXTRA_TESTS or something else ?
>>
> Yes, it's this config symbol.
>
> Horia
>
next prev parent reply other threads:[~2019-06-12 5:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 14:39 [PATCH v2 0/4] Additional fixes on Talitos driver Christophe Leroy
2019-06-11 14:39 ` [PATCH v2 1/4] crypto: talitos - move struct talitos_edesc into talitos.h Christophe Leroy
2019-06-13 12:13 ` Horia Geanta
2019-06-13 12:16 ` Christophe Leroy
2019-06-13 12:24 ` Horia Geanta
2019-06-13 12:32 ` Christophe Leroy
2019-06-13 12:39 ` Horia Geanta
2019-06-13 12:50 ` Christophe Leroy
2019-06-11 14:39 ` [PATCH v2 2/4] crypto: talitos - fix hash on SEC1 Christophe Leroy
2019-06-11 14:39 ` [PATCH v2 3/4] crypto: talitos - eliminate unneeded 'done' functions at build time Christophe Leroy
2019-06-13 12:16 ` Horia Geanta
2019-06-11 14:39 ` [PATCH v2 4/4] crypto: talitos - drop icv_ool Christophe Leroy
2019-06-13 12:21 ` Horia Geanta
2019-06-13 12:28 ` Christophe Leroy
2019-06-13 13:09 ` Herbert Xu
2019-06-11 15:37 ` [PATCH v2 0/4] Additional fixes on Talitos driver Horia Geanta
2019-06-11 15:40 ` Christophe Leroy
2019-06-11 16:30 ` Horia Geanta
2019-06-11 17:16 ` Christophe Leroy
2019-06-12 5:52 ` Christophe Leroy [this message]
2019-06-12 13:59 ` Horia Geanta
2019-06-13 4:57 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58787543-76d3-e0db-9517-ccd0f6494d85@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).