From: Alexander Graf <agraf@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: "aik@ozlabs.ru" <aik@ozlabs.ru>,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"qiudayu@linux.vnet.ibm.com" <qiudayu@linux.vnet.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 4/4] powerpc/eeh: Avoid event on passed PE
Date: Tue, 3 Jun 2014 09:45:27 +0200 [thread overview]
Message-ID: <5C4E374F-0BE1-4BE3-991C-E6BD64E90E6A@suse.de> (raw)
In-Reply-To: <20140603055415.GA24370@iris.ozlabs.ibm.com>
> Am 03.06.2014 um 07:54 schrieb Paul Mackerras <paulus@samba.org>:
>=20
>> On Tue, May 20, 2014 at 01:25:11PM +0200, Alexander Graf wrote:
>>=20
>>> On 20.05.14 10:30, Gavin Shan wrote:
>>> If we detects frozen state on PE that has been passed to guest, we
>>> needn't handle it. Instead, we rely on the guest to detect and recover
>>> it. The patch avoid EEH event on the frozen passed PE so that the guest
>>> can have chance to handle that.
>>>=20
>>> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>>=20
>> How does the guest learn about this failure? We'd need to inject an error=
>> into it, no?
>>=20
>> I think what you want is an irqfd that the in-kernel eeh code notifies wh=
en
>> it sees a failure. When such an fd exists, the kernel skips its own error=
>> handling.
>=20
> Well... we don't have irqfd support for book3s HV upstream yet. The
> way the current code is, we have to turn on GSI routing, which puts a
> hard and relatively small limit on the hardware IRQ numbers we can use
> as it uses a flat array indexed by hardware IRQ number. Which is a
> problem that I need to solve somehow,
Please sync up with the ARM folks on this - they were also unhappy about the=
routing requirements for irqfd ;).
> but it makes using an irqfd
> unattractive in the short term.
For EEH it could as well be a dumb eventfd - really just a side channel that=
can tell user space that something happened asynchronously :).
Alex
next prev parent reply other threads:[~2014-06-03 7:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 8:30 [PATCH RFCv4 0/4] EEH Support for VFIO PCI device Gavin Shan
2014-05-20 8:30 ` [PATCH 1/4] drivers/vfio: Introduce CONFIG_VFIO_PCI_EEH Gavin Shan
2014-05-20 8:30 ` [PATCH 2/4] powerpc/eeh: Flags for passed device and PE Gavin Shan
2014-05-20 8:30 ` [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO Gavin Shan
2014-05-20 11:21 ` Alexander Graf
2014-05-20 11:28 ` Alexander Graf
2014-05-20 11:40 ` Gavin Shan
2014-05-20 11:44 ` Alexander Graf
2014-05-20 12:21 ` Gavin Shan
2014-05-20 12:25 ` Alexander Graf
2014-05-20 12:39 ` Gavin Shan
2014-05-21 0:23 ` Benjamin Herrenschmidt
2014-05-21 4:39 ` Gavin Shan
2014-05-21 6:23 ` Alexander Graf
2014-05-21 7:24 ` Benjamin Herrenschmidt
2014-05-21 10:48 ` Gavin Shan
2014-05-21 0:21 ` Benjamin Herrenschmidt
2014-05-20 8:30 ` [PATCH 4/4] powerpc/eeh: Avoid event on passed PE Gavin Shan
2014-05-20 11:25 ` Alexander Graf
2014-05-20 11:56 ` Gavin Shan
2014-05-20 12:14 ` Alexander Graf
2014-05-20 12:45 ` Gavin Shan
2014-05-20 13:49 ` Alexander Graf
2014-05-21 0:13 ` Benjamin Herrenschmidt
2014-05-21 6:16 ` Alexander Graf
2014-05-21 0:19 ` Benjamin Herrenschmidt
2014-05-21 6:20 ` Alexander Graf
2014-05-21 0:12 ` Benjamin Herrenschmidt
2014-05-21 4:41 ` Gavin Shan
2014-06-03 5:54 ` Paul Mackerras
2014-06-03 7:45 ` Alexander Graf [this message]
2014-06-03 7:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C4E374F-0BE1-4BE3-991C-E6BD64E90E6A@suse.de \
--to=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=qiudayu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).