From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D508AC35679 for ; Mon, 24 Feb 2020 06:00:39 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 677AF20714 for ; Mon, 24 Feb 2020 06:00:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="n91SSWp0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 677AF20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48QryX68QKzDqMm for ; Mon, 24 Feb 2020 17:00:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=c-s.fr (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@c-s.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=c-s.fr header.i=@c-s.fr header.a=rsa-sha256 header.s=mail header.b=n91SSWp0; dkim-atps=neutral Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48QrwR6dP8zDqNy for ; Mon, 24 Feb 2020 16:58:46 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48QrwF3cMyz9v149; Mon, 24 Feb 2020 06:58:37 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=n91SSWp0; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id dq2_HUFjfmjT; Mon, 24 Feb 2020 06:58:37 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48QrwF2XX7z9v148; Mon, 24 Feb 2020 06:58:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1582523917; bh=sd6P6bDbrqs7ItBGISUvE6aNCKAodgqE4OhJmXsYN/s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=n91SSWp0Fk79XdHMBCPUz91F9BSjx8IX9iTLBp/jdL8N6edFvXfYdUniDMdghh9cS IyEDCBOwXlzC89PWRlZUFRcpjcssR85wKq2CRP9hna+sY9zbFM2Xgvh7YRLXlSZCTm lPNro+Y6qls1TdSaQRId3A+ZsUo0sMUvv1S/DHJ0= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C50A48B790; Mon, 24 Feb 2020 06:58:41 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id hr3bcgBgeQo0; Mon, 24 Feb 2020 06:58:41 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 57E938B752; Mon, 24 Feb 2020 06:58:41 +0100 (CET) Subject: Re: [RFC PATCH v2 00/12] Reduce ifdef mess in ptrace To: Michael Neuling References:

<7b86733f81c7e15d81ab14b98c8998011ed54880.camel@neuling.org> From: Christophe Leroy Message-ID: <5b5d8f61-c9aa-1afd-6001-44a17f00c1a6@c-s.fr> Date: Mon, 24 Feb 2020 06:58:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <7b86733f81c7e15d81ab14b98c8998011ed54880.camel@neuling.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 24/02/2020 à 03:15, Michael Neuling a écrit : > Christophe, > >> Le 28/06/2019 à 17:47, Christophe Leroy a écrit : >>> The purpose of this series is to reduce the amount of #ifdefs >>> in ptrace.c >>> >> >> Any feedback on this series which aims at fixing the issue you opened at >> https://github.com/linuxppc/issues/issues/128 ? > > Yeah, sorry my bad. You did all the hard work and I ignored it. > > I like the approach and is a long the lines I was thinking. Putting it in a > ptrace subdir, splitting out adv_debug_regs, TM, SPE, Alitivec, VSX. > ppc_gethwdinfo() looks a lot nicer now too (that was some of the worst of it). > > I've not gone through it with a fine tooth comb though. There is (rightly) a lot > of code moved around which could have introduced some issues. > > It applies on v5.2 but are you planning on updating it to a newer base? > As you noticed there is a lot of code moved around, and rebasing produces a lot of conflicts. So I didn't want to spend hours to rebase and rebase without being sure it was the right approach. Now that I got a positive feedback I'll consider rebasing it, hopping that Michael will pick it up. Christophe