From: Thomas Falcon <tlfalcon@linux.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: nathanl@linux.ibm.com, netdev@vger.kernel.org,
msuchanek@suse.com, tyreld@linux.ibm.com
Subject: Re: [RFC PATCH] powerpc/pseries/mobility: notify network peers after migration
Date: Thu, 7 Nov 2019 15:16:18 -0600 [thread overview]
Message-ID: <601046ba-7bf4-f323-c708-8a5d99c961cd@linux.ibm.com> (raw)
In-Reply-To: <87tv7g5v3e.fsf@mpe.ellerman.id.au>
On 11/6/19 7:33 PM, Michael Ellerman wrote:
> Hi Thomas,
>
> Thomas Falcon <tlfalcon@linux.ibm.com> writes:
>> After a migration, it is necessary to send a gratuitous ARP
>> from all running interfaces so that the rest of the network
>> is aware of its new location. However, some supported network
>> devices are unaware that they have been migrated. To avoid network
>> interruptions and other unwanted behavior, force a GARP on all
>> valid, running interfaces as part of the post_mobility_fixup
>> routine.
>>
>> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
>> ---
>> arch/powerpc/platforms/pseries/mobility.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
> This patch is in powerpc code, but it's doing networking stuff that I
> don't really understand.
>
> So I'd like an Ack from Dave or someone else in netdev land before I
> merge it.
Thanks, I've already included netdev in the CC list. I'll wait and keep
an eye out for any comments from that side.
Tom
>
> cheers
>
>
>> diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
>> index b571285f6c14..c1abc14cf2bb 100644
>> --- a/arch/powerpc/platforms/pseries/mobility.c
>> +++ b/arch/powerpc/platforms/pseries/mobility.c
>> @@ -17,6 +17,9 @@
>> #include <linux/delay.h>
>> #include <linux/slab.h>
>> #include <linux/stringify.h>
>> +#include <linux/netdevice.h>
>> +#include <linux/rtnetlink.h>
>> +#include <net/net_namespace.h>
>>
>> #include <asm/machdep.h>
>> #include <asm/rtas.h>
>> @@ -331,6 +334,8 @@ void post_mobility_fixup(void)
>> {
>> int rc;
>> int activate_fw_token;
>> + struct net_device *netdev;
>> + struct net *net;
>>
>> activate_fw_token = rtas_token("ibm,activate-firmware");
>> if (activate_fw_token == RTAS_UNKNOWN_SERVICE) {
>> @@ -371,6 +376,21 @@ void post_mobility_fixup(void)
>> /* Possibly switch to a new RFI flush type */
>> pseries_setup_rfi_flush();
>>
>> + /* need to force a gratuitous ARP on running interfaces */
>> + rtnl_lock();
>> + for_each_net(net) {
>> + for_each_netdev(net, netdev) {
>> + if (netif_device_present(netdev) &&
>> + netif_running(netdev) &&
>> + !(netdev->flags & (IFF_NOARP | IFF_LOOPBACK)))
>> + call_netdevice_notifiers(NETDEV_NOTIFY_PEERS,
>> + netdev);
>> + call_netdevice_notifiers(NETDEV_RESEND_IGMP,
>> + netdev);
>> + }
>> + }
>> + rtnl_unlock();
>> +
>> return;
>> }
>>
>> --
>> 2.12.3
prev parent reply other threads:[~2019-11-07 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 0:06 [RFC PATCH] powerpc/pseries/mobility: notify network peers after migration Thomas Falcon
2019-11-06 4:13 ` Russell Currey
2019-11-06 4:47 ` Thomas Falcon
2019-11-06 22:14 ` Nathan Lynch
2019-11-07 21:30 ` Thomas Falcon
2019-11-07 1:33 ` Michael Ellerman
2019-11-07 21:16 ` Thomas Falcon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=601046ba-7bf4-f323-c708-8a5d99c961cd@linux.ibm.com \
--to=tlfalcon@linux.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.com \
--cc=nathanl@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).