From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Shawn Anastasio <shawn@anastas.io>,
linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: sbobroff@linux.ibm.com, lukas@wunner.de, oohall@gmail.com,
bhelgaas@google.com
Subject: Re: [PATCH v2 1/1] powerpc/pci: Fix pcibios_setup_device() ordering
Date: Sat, 28 Sep 2019 22:18:42 +1000 [thread overview]
Message-ID: <628b96b2-840c-b18e-538d-a70751b4105b@ozlabs.ru> (raw)
In-Reply-To: <57bb4467-40ab-bdf7-4091-adc0236c3ea3@anastas.io>
On 28/09/2019 04:33, Shawn Anastasio wrote:
> On 9/9/19 2:59 AM, Alexey Kardashevskiy wrote:
>>
>>
>> On 06/09/2019 05:13, Shawn Anastasio wrote:
>>> Move PCI device setup from pcibios_add_device() and pcibios_fixup_bus() to
>>> pcibios_bus_add_device(). This ensures that platform-specific DMA and IOMMU
>>> setup occurs after the device has been registered in sysfs, which is a
>>> requirement for IOMMU group assignment to work
>>>
>>> This fixes IOMMU group assignment for hotplugged devices on pseries, where
>>> the existing behavior results in IOMMU assignment before registration.
>>
>>
>> Although this is a correct approach which we should proceed with, this
>> breaks adding of SRIOV VFs from pnv_tce_iommu_bus_notifier (and possibly
>> the bare metal PCI hotplug), I am trying to fix that now...
>
> Were you able to make any progress? I can think of a couple of ways
> to fix SRIOV, but they're not particularly elegant and involve
> duplication.
A bigger change for ppc+pci is coming from Oliver (I guess with your patch as well) which will tackle this one too, soon.
--
Alexey
prev parent reply other threads:[~2019-09-28 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 19:13 [PATCH v2 0/1] Fix IOMMU setup for hotplugged devices on pseries Shawn Anastasio
2019-09-05 19:13 ` [PATCH v2 1/1] powerpc/pci: Fix pcibios_setup_device() ordering Shawn Anastasio
2019-09-09 7:59 ` Alexey Kardashevskiy
2019-09-27 18:33 ` Shawn Anastasio
2019-09-28 12:18 ` Alexey Kardashevskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=628b96b2-840c-b18e-538d-a70751b4105b@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=oohall@gmail.com \
--cc=sbobroff@linux.ibm.com \
--cc=shawn@anastas.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).