From: Leonardo Bras <leobras.c@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Joel Stanley <joel@jms.id.au>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Niklas Schnelle <schnelle@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 06/11] powerpc/pseries/iommu: Add ddw_property_create() and refactor enable_ddw()
Date: Fri, 30 Apr 2021 13:05:59 -0300 [thread overview]
Message-ID: <63235a71f8bf8f3a44815b7bb6241d3a822e1be7.camel@gmail.com> (raw)
In-Reply-To: <e214f457-fcf0-c9ff-4574-93ed20298119@ozlabs.ru>
On Fri, 2021-04-23 at 19:04 +1000, Alexey Kardashevskiy wrote:
>
> > + win64->name = kstrdup(propname, GFP_KERNEL);
> > + ddwprop = kzalloc(sizeof(*ddwprop), GFP_KERNEL);
> > + win64->value = ddwprop;
> > + win64->length = sizeof(*ddwprop);
> > + if (!win64->name || !win64->value) {
> > + kfree(win64);
> > + kfree(win64->name);
> > + kfree(win64->value);
>
>
> Wrong order.
>
Right! Sorry about that.
Changed for next version!
> >
> >
> > +out_del_win:
>
>
> (I would not bother but since I am commenting on the patch)
>
> nit: the new name is not that much better than the old
> "out_clear_window:" ("out_remove_win" would be a bit better) and it does
> make reviewing a little bit harder. Thanks,
Replaced by out_remove_win
Thanks!
next prev parent reply other threads:[~2021-04-30 16:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 7:07 [PATCH v3 00/11] DDW + Indirect Mapping Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 01/11] powerpc/pseries/iommu: Replace hard-coded page shift Leonardo Bras
2021-04-23 7:27 ` Alexey Kardashevskiy
2021-04-30 15:58 ` Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 02/11] powerpc/kernel/iommu: Add new iommu_table_in_use() helper Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 03/11] powerpc/pseries/iommu: Add iommu_pseries_alloc_table() helper Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 04/11] powerpc/pseries/iommu: Add ddw_list_new_entry() helper Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 05/11] powerpc/pseries/iommu: Allow DDW windows starting at 0x00 Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 06/11] powerpc/pseries/iommu: Add ddw_property_create() and refactor enable_ddw() Leonardo Bras
2021-04-23 9:04 ` Alexey Kardashevskiy
2021-04-30 16:05 ` Leonardo Bras [this message]
2021-04-22 7:07 ` [PATCH v3 07/11] powerpc/pseries/iommu: Reorganize iommu_table_setparms*() with new helper Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 08/11] powerpc/pseries/iommu: Update remove_dma_window() to accept property name Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 09/11] powerpc/pseries/iommu: Find existing DDW with given " Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 10/11] powerpc/pseries/iommu: Make use of DDW for indirect mapping Leonardo Bras
2021-04-22 7:07 ` [PATCH v3 11/11] powerpc/pseries/iommu: Rename "direct window" to "dma window" Leonardo Bras
2021-04-22 7:19 ` [PATCH v3 00/11] DDW + Indirect Mapping Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63235a71f8bf8f3a44815b7bb6241d3a822e1be7.camel@gmail.com \
--to=leobras.c@gmail.com \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nicoleotsuka@gmail.com \
--cc=paulus@samba.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).