From: "Liang He" <windhl@126.com>
To: "Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
Cc: nick.child@ibm.com, linux-kernel@vger.kernel.org,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re:Re: [PATCH] powerpc: powernv: Fix refcount leak bug in opal-powercap
Date: Fri, 17 Jun 2022 22:29:01 +0800 (CST) [thread overview]
Message-ID: <69e7e81b.8204.18172113f39.Coremail.windhl@126.com> (raw)
In-Reply-To: <0ca5ee14-a382-0935-66be-820975501f45@wanadoo.fr>
At 2022-06-17 13:01:27, "Christophe JAILLET" <christophe.jaillet@wanadoo.fr> wrote:
>Le 17/06/2022 à 06:20, Liang He a écrit :
>> In opal_powercap_init(), of_find_compatible_node() will return
>> a node pointer with refcount incremented. We should use of_node_put()
>> in fail path or when it is not used anymore.
>>
>> Besides, for_each_child_of_node() will automatically *inc* and *dec*
>> refcount during iteration. However, we should add the of_node_put()
>> if there is a break.
>
>Hi,
>
>I'm not sure that your patch is right here. Because of this *inc* and
>*dec* things, do we still need to of_node_put(powercap) once we have
>entered for_each_child_of_node?
>
>I think that this reference will be released on the first iteration of
>the loop.
>
>
>Maybe of_node_put(powercap) should be duplicated everywhere it is
>relevant and removed from the error handling path?
>Or an additional reference should be taken before the loop?
>Or adding a new label with "powercap = NULL" and branching there when
>needed?
>
>CJ
>
>>
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>> arch/powerpc/platforms/powernv/opal-powercap.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/powernv/opal-powercap.c b/arch/powerpc/platforms/powernv/opal-powercap.c
>> index 64506b46e77b..b102477d3f95 100644
>> --- a/arch/powerpc/platforms/powernv/opal-powercap.c
>> +++ b/arch/powerpc/platforms/powernv/opal-powercap.c
>> @@ -153,7 +153,7 @@ void __init opal_powercap_init(void)
>> pcaps = kcalloc(of_get_child_count(powercap), sizeof(*pcaps),
>> GFP_KERNEL);
>> if (!pcaps)
>> - return;
>> + goto out_powercap;
>>
>> powercap_kobj = kobject_create_and_add("powercap", opal_kobj);
>> if (!powercap_kobj) {
>> @@ -236,6 +236,9 @@ void __init opal_powercap_init(void)
>> kfree(pcaps[i].pg.name);
>> }
>> kobject_put(powercap_kobj);
>> + of_node_put(node);
>> out_pcaps:
>> kfree(pcaps);
>> +out_powercap:
>> + of_node_put(powercap);
>> }
Hi, CJ.
I think my patch is correct based on the old commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.19-rc2&id=09700c504d8e63faffd2a2235074e8c5d130cb8f
Bugs and fix solutions in this 09700c504d8e63-commit are very similar with mine.
Besides, I also find similar new bugs in other two files in the same directory 'powernv',
so I have merged all three files' patches into one commit. '[PATCH v2] powerpc: powernv: Fix refcount leak bug'.
Thanks.
Liang
prev parent reply other threads:[~2022-06-17 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 4:20 [PATCH] powerpc: powernv: Fix refcount leak bug in opal-powercap Liang He
2022-06-17 5:01 ` Christophe JAILLET
2022-06-17 5:42 ` Liang He
2022-06-18 7:38 ` Christophe JAILLET
2022-06-17 14:29 ` Liang He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69e7e81b.8204.18172113f39.Coremail.windhl@126.com \
--to=windhl@126.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nick.child@ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).