From: Tabi Timur-B04825 <B04825@freescale.com>
To: Tiejun Chen <tiejun.chen@windriver.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jason.wessel@windriver.com" <jason.wessel@windriver.com>
Subject: Re: [PATCH 1/3] powerpc/book3e: load critical/machine/debug exception stack
Date: Tue, 18 Dec 2012 22:10:01 +0000 [thread overview]
Message-ID: <6AE080B68D46FC4BA2D2769E68D765B7081D305D@039-SN2MPN1-023.039d.mgd.msft.net> (raw)
In-Reply-To: <1351147410-17452-1-git-send-email-tiejun.chen@windriver.com>
On Thu, Oct 25, 2012 at 1:43 AM, Tiejun Chen <tiejun.chen@windriver.com> wr=
ote:
> We always alloc critical/machine/debug check exceptions. This is
> different from the normal exception. So we should load these exception
> stack properly like we did for booke.
Tiejun,
I'm a little confused by these patches, because the actual critical
exception handlers are still commented out:
/* Critical Input Interrupt */
START_EXCEPTION(critical_input);
CRIT_EXCEPTION_PROLOG(0x100, BOOKE_INTERRUPT_CRITICAL,
PROLOG_ADDITION_NONE)
// EXCEPTION_COMMON(0x100, PACA_EXCRIT, INTS_DISABLE)
// bl special_reg_save_crit
// CHECK_NAPPING();
// addi r3,r1,STACK_FRAME_OVERHEAD
// bl .critical_exception
// b ret_from_crit_except
b .
Are you working on fixing this? I'm trying to fix it, too, but I
think you're way ahead of me.
--=20
Timur Tabi
Linux kernel developer at Freescale=
next prev parent reply other threads:[~2012-12-18 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 6:43 [PATCH 1/3] powerpc/book3e: load critical/machine/debug exception stack Tiejun Chen
2012-10-25 6:43 ` [PATCH 2/3] powerpc/book3e: support kgdb for kernel space Tiejun Chen
2012-10-25 6:43 ` [PATCH 3/3] kgdb/kgdbts: support ppc64 Tiejun Chen
2012-12-18 22:10 ` Tabi Timur-B04825 [this message]
2012-12-20 9:14 ` [PATCH 1/3] powerpc/book3e: load critical/machine/debug exception stack tiejun.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6AE080B68D46FC4BA2D2769E68D765B7081D305D@039-SN2MPN1-023.039d.mgd.msft.net \
--to=b04825@freescale.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).