linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Daniel Axtens <dja@axtens.net>, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, mikey@neuling.org,
	shuah@kernel.org, linux-kselftest@vger.kernel.org,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v2 1/4] powerpc/selftests/ptrace-hwbreak: Add testcases for 2nd DAWR
Date: Mon, 12 Apr 2021 10:27:24 +0530	[thread overview]
Message-ID: <6a3b2779-ccf5-bd42-f30a-a4ae9d04dac2@linux.ibm.com> (raw)
In-Reply-To: <87mtu8eyqz.fsf@linkitivity.dja.id.au>


On 4/9/21 12:22 PM, Daniel Axtens wrote:
> Hi Ravi,
> 
>> Add selftests to test multiple active DAWRs with ptrace interface.
> 
> It would be good if somewhere (maybe in the cover letter) you explain
> what DAWR stands for and where to find more information about it. I
> found the Power ISA v3.1 Book 3 Chapter 9 very helpful.

Sure. Will add the details in v2 cover letter.

> Apart from that, I don't have any specific comments about this patch. It
> looks good to me, it seems to do what it says, and there are no comments
> from checkpatch. It is a bit sparse in terms of comments but it is
> consistent with the rest of the file so I can't really complain there :)
> 
> Reviewed-by: Daniel Axtens <dja@axtens.net>

Thanks
Ravi

  reply	other threads:[~2021-04-12  4:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  5:49 [PATCH v2 0/4] powerpc/selftests: Add Power10 2nd DAWR selftests Ravi Bangoria
2021-04-07  5:49 ` [PATCH v2 1/4] powerpc/selftests/ptrace-hwbreak: Add testcases for 2nd DAWR Ravi Bangoria
2021-04-09  6:52   ` Daniel Axtens
2021-04-12  4:57     ` Ravi Bangoria [this message]
2021-04-07  5:49 ` [PATCH v2 2/4] powerpc/selftests/perf-hwbreak: Coalesce event creation code Ravi Bangoria
2021-04-09  7:19   ` Daniel Axtens
2021-04-12  5:03     ` Ravi Bangoria
2021-04-07  5:49 ` [PATCH v2 3/4] powerpc/selftests/perf-hwbreak: Add testcases for 2nd DAWR Ravi Bangoria
2021-04-07  5:49 ` [PATCH v2 4/4] powerpc/selftests: Add selftest to test concurrent perf/ptrace events Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a3b2779-ccf5-bd42-f30a-a4ae9d04dac2@linux.ibm.com \
    --to=ravi.bangoria@linux.ibm.com \
    --cc=dja@axtens.net \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).