From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 2/3] powerpc: Show PAGE_SIZE in __die() output
Date: Thu, 10 Jan 2019 14:40:53 +0100 [thread overview]
Message-ID: <6b0e80cc-1664-bdc8-c6aa-a69c5d8b14c6@c-s.fr> (raw)
In-Reply-To: <20190110115737.30931-2-mpe@ellerman.id.au>
Le 10/01/2019 à 12:57, Michael Ellerman a écrit :
> The page size the kernel is built with is useful info when debugging a
> crash, so add it to the output in __die().
>
> Result looks like eg:
>
> kernel BUG at drivers/misc/lkdtm/bugs.c:63!
> Oops: Exception in kernel mode, sig: 5 [#1]
> LE PAGE_SIZE=64K SMP NR_CPUS=2048 NUMA pSeries
> Modules linked in: vmx_crypto kvm binfmt_misc ip_tables
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/kernel/traps.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> v2: Adapt to single printk.
>
> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index 164fc92895be..a872c64618ad 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -257,8 +257,9 @@ static int __die(const char *str, struct pt_regs *regs, long err)
> {
> printk("Oops: %s, sig: %ld [#%d]\n", str, err, ++die_counter);
>
> - printk("%s %s%s%s%s%s %s\n",
> + printk("%s PAGE_SIZE=%luK%s%s%s%s%s %s\n",
> IS_ENABLED(CONFIG_CPU_LITTLE_ENDIAN) ? "LE" : "BE",
> + PAGE_SIZE / 1024,
> IS_ENABLED(CONFIG_PREEMPT) ? " PREEMPT" : "",
> IS_ENABLED(CONFIG_SMP) ? " SMP" : "",
> IS_ENABLED(CONFIG_SMP) ? (" NR_CPUS=" __stringify(NR_CPUS)) : "",
>
next prev parent reply other threads:[~2019-01-10 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 11:57 [PATCH v2 1/3] powerpc: Stop using pr_cont() in __die() Michael Ellerman
2019-01-10 11:57 ` [PATCH v2 2/3] powerpc: Show PAGE_SIZE in __die() output Michael Ellerman
2019-01-10 13:40 ` Christophe Leroy [this message]
2019-01-10 11:57 ` [PATCH v2 3/3] powerpc/64s: Add MMU type to " Michael Ellerman
2019-01-10 13:41 ` Christophe Leroy
2019-01-10 13:40 ` [PATCH v2 1/3] powerpc: Stop using pr_cont() in __die() Christophe Leroy
2019-01-11 10:30 ` Michael Ellerman
2019-01-24 3:40 ` [v2,1/3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b0e80cc-1664-bdc8-c6aa-a69c5d8b14c6@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).