From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-xtensa@linux-xtensa.org,
linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org,
x86@kernel.org, linux-um@lists.infradead.org,
linux-mips@vger.kernel.org, linux-csky@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
openrisc@lists.librecores.org, linux-alpha@vger.kernel.org,
sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-snps-arc@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mm: Define ARCH_HAS_FIRST_USER_ADDRESS
Date: Wed, 14 Apr 2021 11:29:40 +0530 [thread overview]
Message-ID: <6d24d3cc-b2df-f0d7-f4bf-f505f679c77e@arm.com> (raw)
In-Reply-To: <f29ba8e2-3071-c963-1e9f-e8c88526ed8d@csgroup.eu>
On 4/14/21 10:52 AM, Christophe Leroy wrote:
>
>
> Le 14/04/2021 à 04:54, Anshuman Khandual a écrit :
>> Currently most platforms define FIRST_USER_ADDRESS as 0UL duplicating the
>> same code all over. Instead define a new option ARCH_HAS_FIRST_USER_ADDRESS
>> for those platforms which would override generic default FIRST_USER_ADDRESS
>> value 0UL. This makes it much cleaner with reduced code.
>>
>> Cc: linux-alpha@vger.kernel.org
>> Cc: linux-snps-arc@lists.infradead.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-csky@vger.kernel.org
>> Cc: linux-hexagon@vger.kernel.org
>> Cc: linux-ia64@vger.kernel.org
>> Cc: linux-m68k@lists.linux-m68k.org
>> Cc: linux-mips@vger.kernel.org
>> Cc: openrisc@lists.librecores.org
>> Cc: linux-parisc@vger.kernel.org
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Cc: linux-riscv@lists.infradead.org
>> Cc: linux-s390@vger.kernel.org
>> Cc: linux-sh@vger.kernel.org
>> Cc: sparclinux@vger.kernel.org
>> Cc: linux-um@lists.infradead.org
>> Cc: linux-xtensa@linux-xtensa.org
>> Cc: x86@kernel.org
>> Cc: linux-mm@kvack.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> ---
>> arch/alpha/include/asm/pgtable.h | 1 -
>> arch/arc/include/asm/pgtable.h | 6 ------
>> arch/arm/Kconfig | 1 +
>> arch/arm64/include/asm/pgtable.h | 2 --
>> arch/csky/include/asm/pgtable.h | 1 -
>> arch/hexagon/include/asm/pgtable.h | 3 ---
>> arch/ia64/include/asm/pgtable.h | 1 -
>> arch/m68k/include/asm/pgtable_mm.h | 1 -
>> arch/microblaze/include/asm/pgtable.h | 2 --
>> arch/mips/include/asm/pgtable-32.h | 1 -
>> arch/mips/include/asm/pgtable-64.h | 1 -
>> arch/nds32/Kconfig | 1 +
>> arch/nios2/include/asm/pgtable.h | 2 --
>> arch/openrisc/include/asm/pgtable.h | 1 -
>> arch/parisc/include/asm/pgtable.h | 2 --
>> arch/powerpc/include/asm/book3s/pgtable.h | 1 -
>> arch/powerpc/include/asm/nohash/32/pgtable.h | 1 -
>> arch/powerpc/include/asm/nohash/64/pgtable.h | 2 --
>> arch/riscv/include/asm/pgtable.h | 2 --
>> arch/s390/include/asm/pgtable.h | 2 --
>> arch/sh/include/asm/pgtable.h | 2 --
>> arch/sparc/include/asm/pgtable_32.h | 1 -
>> arch/sparc/include/asm/pgtable_64.h | 3 ---
>> arch/um/include/asm/pgtable-2level.h | 1 -
>> arch/um/include/asm/pgtable-3level.h | 1 -
>> arch/x86/include/asm/pgtable_types.h | 2 --
>> arch/xtensa/include/asm/pgtable.h | 1 -
>> include/linux/mm.h | 4 ++++
>> mm/Kconfig | 4 ++++
>> 29 files changed, 10 insertions(+), 43 deletions(-)
>>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index 8ba434287387..47098ccd715e 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -46,6 +46,10 @@ extern int sysctl_page_lock_unfairness;
>> void init_mm_internals(void);
>> +#ifndef ARCH_HAS_FIRST_USER_ADDRESS
>
> I guess you didn't test it ..... :)
In fact I did :) Though just booted it on arm64 and cross compiled on
multiple others platforms.
>
> should be #ifndef CONFIG_ARCH_HAS_FIRST_USER_ADDRESS
Right, meant that instead.
>
>> +#define FIRST_USER_ADDRESS 0UL
>> +#endif
>
> But why do we need a config option at all for that ?
>
> Why not just:
>
> #ifndef FIRST_USER_ADDRESS
> #define FIRST_USER_ADDRESS 0UL
> #endif
This sounds simpler. But just wondering, would not there be any possibility
of build problems due to compilation sequence between arch and generic code ?
next prev parent reply other threads:[~2021-04-14 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 2:54 [PATCH] mm: Define ARCH_HAS_FIRST_USER_ADDRESS Anshuman Khandual
2021-04-14 5:22 ` Christophe Leroy
2021-04-14 5:59 ` Anshuman Khandual [this message]
2021-04-14 6:10 ` Christophe Leroy
2021-04-15 4:40 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d24d3cc-b2df-f0d7-f4bf-f505f679c77e@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=openrisc@lists.librecores.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).