From: Michael Neuling <mikey@neuling.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Brian King <brking@linux.vnet.ibm.com>,
Tim Abbott <tabbott@ksplice.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: 64K PAGE_SIZE and arch/powerpc/kernel/vdso.c
Date: Mon, 18 Oct 2010 10:44:12 +1100 [thread overview]
Message-ID: <7015.1287359052@neuling.org> (raw)
In-Reply-To: <1287216239.9909.234.camel@haakon2.linux-iscsi.org>
> Greetings Linux-ppc64 folks,
>=20
> While trying to compile v2.6.36-rc8 with PAGE_SIZE=3D65536 I run into the
> following compile failure w/ strict checking on a RHEL5.4 / gcc (GCC)
> 4.1.2 20080704 (Red Hat 4.1.2-46) system:
>=20
> cc1: warnings being treated as errors
> arch/powerpc/kernel/vdso.c:81: warning: alignment of =E2=80=98vdso_data_s=
tore=E2=80=99
> is greater than maximum object file alignment. Using 32768
> CC arch/powerpc/sysdev/msi_bitmap.o
> make[1]: *** [arch/powerpc/kernel/vdso.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
>=20
> Any ideas folks..?
It seems this broke it:
commit abe1ee3a221d53778c3e58747bbec6e518e5471b
Author: Tim Abbott <tabbott@ksplice.com>
Date: Sun Sep 20 18:14:15 2009 -0400
Use macros for .data.page_aligned section.
=20=20=20=20
This patch changes the remaining direct references to
.data.page_aligned in C and assembly code to use the macros in
include/linux/linkage.h.
Backing out just that part of the change (see below) fixes it.
FYI the error only occurs on gcc 4.1 and 4.2. 4.3 and greater is fine.=20=
=20
Mikey
diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c
index 13002fe..c140fce 100644
--- a/arch/powerpc/kernel/vdso.c
+++ b/arch/powerpc/kernel/vdso.c
@@ -78,7 +78,7 @@ static int vdso_ready;
static union {
struct vdso_data data;
u8 page[PAGE_SIZE];
-} vdso_data_store __page_aligned_data;
+} vdso_data_store __attribute__((__section__(".data.page_aligned")));
struct vdso_data *vdso_data =3D &vdso_data_store.data;
=20
/* Format of the patch table */
next prev parent reply other threads:[~2010-10-17 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 8:03 64K PAGE_SIZE and arch/powerpc/kernel/vdso.c Nicholas A. Bellinger
2010-10-17 23:44 ` Michael Neuling [this message]
2010-10-18 10:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7015.1287359052@neuling.org \
--to=mikey@neuling.org \
--cc=brking@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nab@linux-iscsi.org \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).