From: Randy Dunlap <rdunlap@infradead.org>
To: PowerPC <linuxppc-dev@lists.ozlabs.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr
Date: Sat, 17 Apr 2021 13:17:59 -0700 [thread overview]
Message-ID: <7107fcae-5c7a-ac94-8d89-326f2cd4cd33@infradead.org> (raw)
Hi,
kernel test robot reports:
>> drivers/cpufreq/pmac32-cpufreq.c:262:2: error: implicit declaration of function 'enable_kernel_fp' [-Werror,-Wimplicit-function-declaration]
enable_kernel_fp();
^
when
# CONFIG_PPC_FPU is not set
CONFIG_ALTIVEC=y
I see at least one other place that does not handle that
combination well, here:
../arch/powerpc/lib/sstep.c: In function 'do_vec_load':
../arch/powerpc/lib/sstep.c:637:3: error: implicit declaration of function 'put_vr' [-Werror=implicit-function-declaration]
637 | put_vr(rn, &u.v);
| ^~~~~~
../arch/powerpc/lib/sstep.c: In function 'do_vec_store':
../arch/powerpc/lib/sstep.c:660:3: error: implicit declaration of function 'get_vr'; did you mean 'get_oc'? [-Werror=implicit-function-declaration]
660 | get_vr(rn, &u.v);
| ^~~~~~
Should the code + Kconfigs/Makefiles handle that kind of
kernel config or should ALTIVEC always mean PPC_FPU as well?
I have patches to fix the build errors with the config as
reported but I don't know if that's the right thing to do...
thanks.
--
~Randy
next reply other threads:[~2021-04-17 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 20:17 Randy Dunlap [this message]
2021-04-18 16:24 ` PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr Christophe Leroy
2021-04-18 17:46 ` Segher Boessenkool
2021-04-18 17:59 ` Randy Dunlap
2021-04-19 13:16 ` Michael Ellerman
2021-04-19 17:59 ` Randy Dunlap
2021-04-19 21:39 ` Randy Dunlap
2021-04-20 4:55 ` Christophe Leroy
2021-04-20 13:15 ` Michael Ellerman
2021-04-20 18:25 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7107fcae-5c7a-ac94-8d89-326f2cd4cd33@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).