From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A568CA9EC7 for ; Tue, 5 Nov 2019 06:06:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFDC220818 for ; Tue, 5 Nov 2019 06:06:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="KyEn44Cv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFDC220818 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 476fLM2yxQzF42h for ; Tue, 5 Nov 2019 17:06:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=c-s.fr (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@c-s.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=c-s.fr header.i=@c-s.fr header.b="KyEn44Cv"; dkim-atps=neutral Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 476fHw4W45zF33m for ; Tue, 5 Nov 2019 17:04:09 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 476fHm3bMCz9vBhW; Tue, 5 Nov 2019 07:04:04 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=KyEn44Cv; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id bejW4i8ArN-f; Tue, 5 Nov 2019 07:04:04 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 476fHm0pfBz9vBhF; Tue, 5 Nov 2019 07:04:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1572933844; bh=PeaCk2RM7ni/Qntm+XOM7dRGcnogK0Sbq44rYc/HpuU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=KyEn44CvaCa8j0axto9vX0/fxpQkhypUIXYb4isqyYXIJ2G0IE6HS26IzquBC5WO+ tzdya5ntaMhkh5qMI/o1gjvODTjcK/dVhqbcWGmQp3QJVK+pnmOrKEQHkkApnFCvEV DE+lfFywsNr7DDcwdwq7hfwnwQPqnrguP/LZA/bY= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D98818B787; Tue, 5 Nov 2019 07:04:04 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id z_R164XR8XJY; Tue, 5 Nov 2019 07:04:04 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2C1AD8B752; Tue, 5 Nov 2019 07:04:04 +0100 (CET) Subject: Re: [PATCH v5 1/6] powerpc: Allow flush_icache_range to work across ranges >4GB To: Segher Boessenkool , Alastair D'Silva References: <20191104023305.9581-1-alastair@au1.ibm.com> <20191104023305.9581-2-alastair@au1.ibm.com> <20191104194357.GE16031@gate.crashing.org> From: Christophe Leroy Message-ID: <74435ba6-51dc-1dff-b55b-cdcf85e2e302@c-s.fr> Date: Tue, 5 Nov 2019 07:04:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191104194357.GE16031@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Nicholas Piggin , Paul Mackerras , stable@vger.kernel.org, alastair@d-silva.org, Qian Cai , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Andrew Morton , Allison Randal Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 04/11/2019 à 20:43, Segher Boessenkool a écrit : > On Mon, Nov 04, 2019 at 01:32:53PM +1100, Alastair D'Silva wrote: >> When calling flush_icache_range with a size >4GB, we were masking >> off the upper 32 bits, so we would incorrectly flush a range smaller >> than intended. >> >> This patch replaces the 32 bit shifts with 64 bit ones, so that >> the full size is accounted for. > > Please send this separately, to be committed right now? It is a bug fix, > independent of the rest of the series. > Patch 4/6 needs it, as it drops the function. Or do you mean that the series should drop the assembly at once, and this patch should only go into stable ? But I guess mpe can take this patch alone if he wants to ? By the way, Patch 2/6 is also a bugfix. Christophe