From: Kumar Gala <galak@kernel.crashing.org>
To: Remi Machet <rmachet@slac.stanford.edu>
Cc: Linux PPC <linuxppc-dev@ozlabs.org>
Subject: Re: New dma-noncoherent code, looking for comment and people to test
Date: Mon, 29 Sep 2008 13:03:11 -0500 [thread overview]
Message-ID: <77D91812-7338-462D-8361-A9A55869D515@kernel.crashing.org> (raw)
In-Reply-To: <1222709165.8628.4.camel@pcds-ts102.slac.stanford.edu>
On Sep 29, 2008, at 12:26 PM, Remi Machet wrote:
> Hi,
>
> I rewrote dma-noncoherent.c and I am looking for people to review
> and test it
> on various platforms that use it to make sure I did not introduce
> any bug.
> The platforms affected by this change are those that define
> CONFIG_NOT_COHERENT_CACHE:
> ppc44x
> walnut
> makalu
> kilauea
> ep405
> adder875
> ep88xc
> taishan
> warp
> sam440ep
> sequoia
> bamboo
> canyonlands
> rainier
> katmai
> ebony
> mpc885_ads
> mpc866_ads
> ppc40x
> c2k (already tested)
> prpmc2800
>
> The old code in dma-noncoherent.c uses a memory pool at a hard coded
> virtual address set by CONFIG_CONSISTENT_START (typically
> 0xFF100000). If not
> set carefully this address can conflict with early ioremap in systems
> that enable HIGHMEM, on top of that the code is overly complex
> because it
> needs to have its own memory manager.
> This is why I tried to re-implement the code using standard memory
> management APIs. The new code does not require the user to set
> CONFIG_CONSISTENT_START or CONFIG_CONSISTENT_SIZE, is much smaller and
> simplier. It also can allocate as much memory as available in ZONE_DMA
> (instead of being limited by CONFIG_CONSISTENT_SIZE).
>
> I also removed the HIGHMEM support in dma_sync since memory
> allocated for
> DMA transfer should always be in ZONE_DMA (ie not in ZONE_HIGHMEM).
>
> Looking forward to any comment about why this code may not work or
> is not
> as good as the original. If you do test this code on your platform,
> let me
> know how it goes ... if no-one object and no bug is found I will
> submit
> this patch in a month or so.
>
> Thanks !
>
> Remi
We really should change this code over to the new dma changes Becky's
introduced so we just have a non-coherent set of DMA ops (thus we can
do both non-coherent and coherent in the same system).
- k
next prev parent reply other threads:[~2008-09-29 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 17:26 New dma-noncoherent code, looking for comment and people to test Remi Machet
2008-09-29 18:03 ` Kumar Gala [this message]
2008-09-29 18:22 ` Remi Machet
2008-09-29 18:39 ` Kumar Gala
2008-09-30 7:21 ` Benjamin Herrenschmidt
2008-09-30 7:21 ` Benjamin Herrenschmidt
2008-09-30 16:27 ` Remi Machet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77D91812-7338-462D-8361-A9A55869D515@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rmachet@slac.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).