From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: alsa-devel@alsa-project.org, Timur Tabi <timur@kernel.org>,
Xiubo Li <Xiubo.Lee@gmail.com>,
tiwai@suse.de,
"open list:FREESCALE SOC SOUND DRIVERS"
<linuxppc-dev@lists.ozlabs.org>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
broonie@kernel.org, Fabio Estevam <festevam@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] ASoC: fsl: fsl-asoc-card: fix kernel-doc
Date: Thu, 2 Jul 2020 14:03:21 -0500 [thread overview]
Message-ID: <7c6fac59-562c-d3b5-8eea-3e0f450cee6b@linux.intel.com> (raw)
In-Reply-To: <20200702184727.GD23935@Asurada-Nvidia>
On 7/2/20 1:47 PM, Nicolin Chen wrote:
> On Thu, Jul 02, 2020 at 12:22:24PM -0500, Pierre-Louis Bossart wrote:
>> Fix W=1 warnings. Kernel-doc syntax was not properly used.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> ---
>> sound/soc/fsl/fsl-asoc-card.c | 21 +++++++++------------
>> 1 file changed, 9 insertions(+), 12 deletions(-)
>>
>> diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
>
>> /**
>> - * Freescale Generic ASOC card private data
>> + * struct fsl_asoc_card_priv - struct Freescale Generic ASOC card private data
>
> Just a nit, can you drop the "struct" before "Freescale"?
> Other parts of your changes don't really add this word.
will do, thanks for spotting this.
> Otherwise,
> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
>
next prev parent reply other threads:[~2020-07-02 19:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200702172227.164474-1-pierre-louis.bossart@linux.intel.com>
2020-07-02 17:22 ` [PATCH 1/6] ASoC: fsl: fsl_ssi_dbg: remove spurious kernel-doc comment start Pierre-Louis Bossart
2020-07-02 18:43 ` Nicolin Chen
2020-07-02 17:22 ` [PATCH 2/6] ASoC: fsl: fsl_ssi: fix kernel-doc Pierre-Louis Bossart
2020-07-02 18:44 ` Nicolin Chen
2020-07-02 17:22 ` [PATCH 3/6] ASoC: fsl: fsl-asoc-card: " Pierre-Louis Bossart
2020-07-02 18:47 ` Nicolin Chen
2020-07-02 19:03 ` Pierre-Louis Bossart [this message]
2020-07-02 17:22 ` [PATCH 4/6] ASoC: fsl: fsl_spdif: " Pierre-Louis Bossart
2020-07-02 18:48 ` Nicolin Chen
2020-07-02 17:22 ` [PATCH 5/6] ASoC: fsl: fsl_asrc: " Pierre-Louis Bossart
2020-07-02 18:51 ` Nicolin Chen
2020-07-02 17:22 ` [PATCH 6/6] ASoC: fsl: fsl_esai: " Pierre-Louis Bossart
2020-07-02 18:55 ` Nicolin Chen
2020-07-02 19:03 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c6fac59-562c-d3b5-8eea-3e0f450cee6b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).