From: Tyrel Datwyler <tyreld@linux.ibm.com>
To: Michael Bringmann <mwb@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Gustavo Walbon <gwalbon@linux.ibm.com>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v2] Fix display of Maximum Memory
Date: Wed, 15 Jan 2020 16:07:49 -0800 [thread overview]
Message-ID: <7f8f6e88-8187-d690-13cb-dae0e47c313b@linux.ibm.com> (raw)
In-Reply-To: <5577aef8-1d5a-ca95-ff0a-9c7b5977e5bf@linux.ibm.com>
On 1/15/20 6:53 AM, Michael Bringmann wrote:
> Correct overflow problem in calculation+display of Maximum Memory
> value to syscfg where 32bits is insufficient.
>
Probably needs the following Fixes tag:
Fixes: 772b039fd9a7 ("powerpc/pseries: Export maximum memory value")
otherwise,
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> Signed-off-by: Michael Bringmann <mwb@linux.ibm.com>
> ---
> arch/powerpc/platforms/pseries/lparcfg.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/platforms/pseries/lparcfg.c b/arch/powerpc/platforms/pseries/lparcfg.c
> index e33e8bc..f00411c 100644
> --- a/arch/powerpc/platforms/pseries/lparcfg.c
> +++ b/arch/powerpc/platforms/pseries/lparcfg.c
> @@ -433,12 +433,12 @@ static void parse_em_data(struct seq_file *m)
>
> static void maxmem_data(struct seq_file *m)
> {
> - unsigned long maxmem = 0;
> + u64 maxmem = 0;
>
> - maxmem += drmem_info->n_lmbs * drmem_info->lmb_size;
> - maxmem += hugetlb_total_pages() * PAGE_SIZE;
> + maxmem += (u64)drmem_info->n_lmbs * drmem_info->lmb_size;
> + maxmem += (u64)hugetlb_total_pages() * PAGE_SIZE;
>
> - seq_printf(m, "MaxMem=%ld\n", maxmem);
> + seq_printf(m, "MaxMem=%llu\n", maxmem);
> }
>
> static int pseries_lparcfg_data(struct seq_file *m, void *v)
>
next prev parent reply other threads:[~2020-01-16 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 14:53 [PATCH v2] Fix display of Maximum Memory Michael Bringmann
2020-01-15 14:55 ` Christophe Leroy
2020-01-16 0:07 ` Tyrel Datwyler [this message]
2020-01-16 5:53 ` Michael Ellerman
2020-01-16 23:52 ` Michael Bringmann
2020-01-29 5:17 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f8f6e88-8187-d690-13cb-dae0e47c313b@linux.ibm.com \
--to=tyreld@linux.ibm.com \
--cc=gwalbon@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mwb@linux.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).