From: Guenter Roeck <linux@roeck-us.net>
To: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com
Subject: Re: [PATCH v4 3/3] hwmon: Document the sensor enable attribute
Date: Sun, 8 Jul 2018 15:50:26 -0700 [thread overview]
Message-ID: <7f9c672a-ae52-0bb3-8820-22049c445a4e@roeck-us.net> (raw)
In-Reply-To: <1530878166-12589-4-git-send-email-shilpa.bhat@linux.vnet.ibm.com>
On 07/06/2018 04:56 AM, Shilpasri G Bhat wrote:
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Applied to hwmon-next, after updating the commit description.
I also removed the text "This attribute can be used as per-sensor or
per-sub-group attribute depending on what is supported by the hardware."
from the attribute descriptions; this is an implementation detail
which should be described in driver documentations.
Thanks,
Guenter
> ---
> Documentation/hwmon/sysfs-interface | 62 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index fc337c3..f865dd7 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -171,6 +171,15 @@ in[0-*]_label Suggested voltage channel label.
> user-space.
> RO
>
> +in[0-*]_enable
> + Enable or disable the sensors.
> + When disabled the sensor read will return -ENODATA. This
> + attribute can be used as per-sensor or per-sub-group attribute
> + depending on what is supported by the hardware.
> + 1: Enable
> + 0: Disable
> + RW
> +
> cpu[0-*]_vid CPU core reference voltage.
> Unit: millivolt
> RO
> @@ -236,6 +245,15 @@ fan[1-*]_label Suggested fan channel label.
> In all other cases, the label is provided by user-space.
> RO
>
> +fan[1-*]_enable
> + Enable or disable the sensors.
> + When disabled the sensor read will return -ENODATA. This
> + attribute can be used as per-sensor or per-sub-group attribute
> + depending on what is supported by the hardware.
> + 1: Enable
> + 0: Disable
> + RW
> +
> Also see the Alarms section for status flags associated with fans.
>
>
> @@ -409,6 +427,15 @@ temp_reset_history
> Reset temp_lowest and temp_highest for all sensors
> WO
>
> +temp[1-*]_enable
> + Enable or disable the sensors.
> + When disabled the sensor read will return -ENODATA. This
> + attribute can be used as per-sensor or per-sub-group attribute
> + depending on what is supported by the hardware.
> + 1: Enable
> + 0: Disable
> + RW
> +
> Some chips measure temperature using external thermistors and an ADC, and
> report the temperature measurement as a voltage. Converting this voltage
> back to a temperature (or the other way around for limits) requires
> @@ -468,6 +495,15 @@ curr_reset_history
> Reset currX_lowest and currX_highest for all sensors
> WO
>
> +curr[1-*]_enable
> + Enable or disable the sensors.
> + When disabled the sensor read will return -ENODATA. This
> + attribute can be used as per-sensor or per-sub-group attribute
> + depending on what is supported by the hardware.
> + 1: Enable
> + 0: Disable
> + RW
> +
> Also see the Alarms section for status flags associated with currents.
>
> *********
> @@ -566,6 +602,15 @@ power[1-*]_crit Critical maximum power.
> Unit: microWatt
> RW
>
> +power[1-*]_enable Enable or disable the sensors.
> + When disabled the sensor read will return
> + -ENODATA. This attribute can be used as
> + per-sensor or per-sub-group attribute depending
> + on what is supported by the hardware.
> + 1: Enable
> + 0: Disable
> + RW
> +
> Also see the Alarms section for status flags associated with power readings.
>
> **********
> @@ -576,6 +621,14 @@ energy[1-*]_input Cumulative energy use
> Unit: microJoule
> RO
>
> +energy[1-*]_enable Enable or disable the sensors.
> + When disabled the sensor read will return
> + -ENODATA. This attribute can be used as
> + per-sensor or per-sub-group attribute depending
> + on what is supported by the hardware.
> + 1: Enable
> + 0: Disable
> + RW
>
> ************
> * Humidity *
> @@ -586,6 +639,15 @@ humidity[1-*]_input Humidity
> RO
>
>
> +humidity[1-*]_enable Enable or disable the sensors
> + When disabled the sensor read will return
> + -ENODATA. This attribute can be used as
> + per-sensor or per-sub-group attribute depending
> + on what is supported by the hardware.
> + 1: Enable
> + 0: Disable
> + RW
> +
> **********
> * Alarms *
> **********
>
prev parent reply other threads:[~2018-07-08 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 11:56 [PATCH v4 0/3] hwmon: Add attributes to enable/disable sensors Shilpasri G Bhat
2018-07-06 11:56 ` [PATCH v4 1/3] powernv:opal-sensor-groups: Add support to enable sensor groups Shilpasri G Bhat
2018-07-06 11:56 ` [PATCH v4 2/3] hwmon: ibmpowernv: Add attributes to enable/disable " Shilpasri G Bhat
2018-07-08 23:01 ` Guenter Roeck
2018-07-06 11:56 ` [PATCH v4 3/3] hwmon: Document the sensor enable attribute Shilpasri G Bhat
2018-07-08 22:50 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f9c672a-ae52-0bb3-8820-22049c445a4e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).