From: Josh Poimboeuf <jpoimboe@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: juri.lelli@redhat.com, dalias@libc.org,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
peterz@infradead.org, catalin.marinas@arm.com,
dave.hansen@linux.intel.com, x86@kernel.org,
jiaxun.yang@flygoat.com, bsegall@google.com, jcmvbkbc@gmail.com,
guoren@kernel.org, hpa@zytor.com, sparclinux@vger.kernel.org,
kernel@xen0n.name, will@kernel.org, vschneid@redhat.com,
f.fainelli@gmail.com, vincent.guittot@linaro.org,
ysato@users.sourceforge.jp, chenhuacai@kernel.org,
linux@armlinux.org.uk, linux-csky@vger.kernel.org,
mingo@redhat.com, bcm-kernel-feedback-list@broadcom.com,
mgorman@suse.de, mattst88@gmail.com,
linux-xtensa@linux-xtensa.org, paulmck@kernel.org,
richard.henderson@linaro.org, npiggin@gmail.com,
ink@jurassic.park.msu.ru, rostedt@goodmis.org,
loongarch@lists.linux.dev, tglx@linutronix.de,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
jgross@suse.com, chris@zankel.net, tsbogend@alpha.franken.de,
bristot@redhat.com, linux-mips@vger.kernel.org,
linux-alph a@vger.kernel.org, bp@alien8.de,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: [PATCH v2 22/24] objtool: Include weak functions in 'global_noreturns' check
Date: Mon, 13 Feb 2023 23:05:56 -0800 [thread overview]
Message-ID: <85c4281eecd9388e7b3b21ef550119caa5305327.1676358308.git.jpoimboe@kernel.org> (raw)
In-Reply-To: <cover.1676358308.git.jpoimboe@kernel.org>
If a global __noreturn function prototype has a corresponding weak
function, it should also be __noreturn.
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
tools/objtool/check.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index ba07a8ebaf73..0a1cf867d9b2 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -193,14 +193,14 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
if (!func)
return false;
- if (func->bind == STB_WEAK)
- return false;
-
- if (func->bind == STB_GLOBAL)
+ if (func->bind == STB_GLOBAL || func->bind == STB_WEAK)
for (i = 0; i < ARRAY_SIZE(global_noreturns); i++)
if (!strcmp(func->name, global_noreturns[i]))
return true;
+ if (func->bind == STB_WEAK)
+ return false;
+
if (!func->len)
return false;
--
2.39.1
next prev parent reply other threads:[~2023-02-14 7:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 7:05 [PATCH v2 00/24] cpu,sched: Mark arch_cpu_idle_dead() __noreturn Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 01/24] alpha/cpu: Expose arch_cpu_idle_dead()'s prototype declaration Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 02/24] alpha/cpu: Make sure arch_cpu_idle_dead() doesn't return Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 03/24] arm/cpu: " Josh Poimboeuf
2023-02-14 11:15 ` Russell King (Oracle)
2023-02-14 18:39 ` Josh Poimboeuf
2023-02-14 22:01 ` Russell King (Oracle)
2023-02-16 18:38 ` [PATCH v2.1 03/24] arm/cpu: Add unreachable() to arch_cpu_idle_dead() Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 04/24] arm64/cpu: Mark cpu_die() __noreturn Josh Poimboeuf
2023-02-14 8:13 ` Philippe Mathieu-Daudé
2023-02-15 13:09 ` Mark Rutland
2023-02-15 19:45 ` Josh Poimboeuf
2023-02-16 18:41 ` [PATCH v2.1 " Josh Poimboeuf
2023-03-02 10:55 ` Philippe Mathieu-Daudé
2023-02-14 7:05 ` [PATCH v2 05/24] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 06/24] ia64/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-02-14 8:07 ` Philippe Mathieu-Daudé
2023-02-14 7:05 ` [PATCH v2 07/24] loongarch/cpu: Make sure play_dead() doesn't return Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 08/24] loongarch/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-02-14 8:06 ` Philippe Mathieu-Daudé
2023-02-14 7:05 ` [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition Josh Poimboeuf
2023-02-14 7:46 ` Philippe Mathieu-Daudé
2023-02-14 18:11 ` Josh Poimboeuf
2023-02-15 8:29 ` Philippe Mathieu-Daudé
2023-02-16 18:42 ` [PATCH v2.1 " Josh Poimboeuf
2023-03-01 18:16 ` Josh Poimboeuf
2023-03-02 10:54 ` Philippe Mathieu-Daudé
2023-02-14 7:05 ` [PATCH v2 10/24] mips/cpu: Make sure play_dead() doesn't return Josh Poimboeuf
2023-02-14 7:50 ` Philippe Mathieu-Daudé
2023-02-14 7:05 ` [PATCH v2 11/24] mips/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-02-14 7:50 ` Philippe Mathieu-Daudé
2023-02-14 7:05 ` [PATCH v2 12/24] powerpc/cpu: Mark start_secondary_resume() __noreturn Josh Poimboeuf
2023-02-14 7:19 ` Christophe Leroy
2023-02-14 7:05 ` [PATCH v2 13/24] sh/cpu: Make sure play_dead() doesn't return Josh Poimboeuf
2023-02-14 7:57 ` Philippe Mathieu-Daudé
2023-02-14 18:28 ` Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 14/24] sh/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 15/24] sh/cpu: Expose arch_cpu_idle_dead()'s prototype definition Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 16/24] sparc/cpu: Mark cpu_play_dead() __noreturn Josh Poimboeuf
2023-02-14 7:52 ` Philippe Mathieu-Daudé
2023-02-14 7:05 ` [PATCH v2 17/24] x86/cpu: Make sure play_dead() doesn't return Josh Poimboeuf
2023-02-14 8:05 ` Philippe Mathieu-Daudé
2023-02-14 7:05 ` [PATCH v2 18/24] x86/cpu: Mark play_dead() __noreturn Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return Josh Poimboeuf
2023-02-14 7:55 ` Philippe Mathieu-Daudé
2023-02-14 18:23 ` Josh Poimboeuf
2023-02-14 19:29 ` Steven Rostedt
2023-02-14 19:48 ` Max Filippov
2023-02-14 20:19 ` Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 20/24] xtensa/cpu: Mark cpu_die() __noreturn Josh Poimboeuf
2023-02-14 12:47 ` Max Filippov
2023-02-14 7:05 ` [PATCH v2 21/24] sched/idle: Make sure weak version of arch_cpu_idle_dead() doesn't return Josh Poimboeuf
2023-02-14 7:05 ` Josh Poimboeuf [this message]
2023-02-14 7:05 ` [PATCH v2 23/24] init: Make arch_call_rest_init() and rest_init() __noreturn Josh Poimboeuf
2023-02-14 7:05 ` [PATCH v2 24/24] sched/idle: Mark arch_cpu_idle_dead() __noreturn Josh Poimboeuf
2023-02-14 9:25 ` [PATCH v2 00/24] cpu,sched: " Philippe Mathieu-Daudé
2023-02-14 18:29 ` Josh Poimboeuf
2023-02-15 22:22 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85c4281eecd9388e7b3b21ef550119caa5305327.1676358308.git.jpoimboe@kernel.org \
--to=jpoimboe@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=f.fainelli@gmail.com \
--cc=guoren@kernel.org \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=jgross@suse.com \
--cc=jiaxun.yang@flygoat.com \
--cc=juri.lelli@redhat.com \
--cc=kernel@xen0n.name \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@armlinux.org.uk \
--cc=loongarch@lists.linux.dev \
--cc=mattst88@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=rostedt@goodmis.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).