linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <oss@buserror.net>
To: Darren Stevens <darren@stevens-zone.net>, linuxppc-dev@lists.ozlabs.org
Cc: chzigotzky@xenosoft.de
Subject: Re: [PATCH] powerpc/85xx: Activate Cyrus disk-activity LED
Date: Tue, 12 Feb 2019 15:35:32 -0600	[thread overview]
Message-ID: <86a59a19d817826f7efca5fab253bddb732eb9d1.camel@buserror.net> (raw)
In-Reply-To: <4d531fb8828.51b92386@auth.smtp.1and1.co.uk>

On Sat, 2019-02-09 at 23:14 +0000, Darren Stevens wrote:
> The disk activity LED on the Cyrus board is attached to a gpio pin,
> add the required device-tree node for the kernel driver to use.
> 
> Signed-off-by: Darren Stevens <darren@stevens-zone.net>
> 
> ---
> 
> diff --git a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> index 15e8440..348cfdb 100644
> --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> +++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> @@ -82,6 +82,15 @@
>             gpios = <&gpio0 2 1>;
>         };
>  
> +       leds {
> +           compatible = "gpio-leds";
> +
> +           hdd {
> +               label = "Disk Activity";
> +               gpios = <&gpio0 5 0>;
> +               linux,default-trigger = "disk-activity";
> +           };
> +       };
>     };

This patch is whitespace-mangled (as is your other one).  Could you try
sending with git send-email?

-Scott



      reply	other threads:[~2019-02-12 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 23:14 [PATCH] powerpc/85xx: Activate Cyrus disk-activity LED Darren Stevens
2019-02-12 21:35 ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a59a19d817826f7efca5fab253bddb732eb9d1.camel@buserror.net \
    --to=oss@buserror.net \
    --cc=chzigotzky@xenosoft.de \
    --cc=darren@stevens-zone.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).