From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9344C433EF for ; Tue, 15 Feb 2022 11:27:47 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Jyf2n6xd8z3cX7 for ; Tue, 15 Feb 2022 22:27:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=M5vUQHwI; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Jyf230fKbz30Ld for ; Tue, 15 Feb 2022 22:27:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=M5vUQHwI; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Jyf1z0Wlgz4xcY; Tue, 15 Feb 2022 22:27:02 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1644924423; bh=2bjEo/l1VuKsDDnpXHRYc8XcSJyXSTPJfQq6nV/jw5E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=M5vUQHwI7ONB8kQMJ2wuRbKHkhWQnv9vfiQPxHQjVjnkycLnHlI60AS+hKyV0yFO9 a/JDvNI9HrfJb/XGRVYj8rYKZZ/oUnBgy3sDzTxpuFxk2LHP7dReNi0dbOQ06aNMKZ BCxeS8wb2bhs3FOz6CvIS2a6TgbRPXtbuHY0YGWsoeWokXouX3GAIOWlUdjse87WrN W7EL7hEB14XBpCq8wvmtkT/d7butip3fEdhlj4X3Vsk3nqJSkJUNE95w/FHY3dPKao CoJR36nYvgRQGtHj5UaAmRA2bx2lE7yJ1c4QHG54XUPkZwaGTsYgIu0Tvhdc2GbryG 3YwasqFGBQRuQ== From: Michael Ellerman To: Wedson Almeida Filho Subject: Re: [PATCH] powerpc/module_64: use module_init_section instead of patching names In-Reply-To: References: <20220202055123.2144842-1-wedsonaf@google.com> Date: Tue, 15 Feb 2022 22:27:02 +1100 Message-ID: <8735kknzeh.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Wedson Almeida Filho writes: > Hi Michael, > > On Wed, 2 Feb 2022 at 05:53, Wedson Almeida Filho wrote: >> >> Without this patch, module init sections are disabled by patching their >> names in arch-specific code when they're loaded (which prevents code in >> layout_sections from finding init sections). This patch uses the new >> arch-specific module_init_section instead. >> >> This allows modules that have .init_array sections to have the >> initialisers properly called (on load, before init). Without this patch, >> the initialisers are not called because .init_array is renamed to >> _init_array, and thus isn't found by code in find_module_sections(). >> >> Signed-off-by: Wedson Almeida Filho >> --- >> arch/powerpc/kernel/module_64.c | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) ... > > Would any additional clarification from my part be helpful here? Just more patience ;) > I got an email saying it was under review (and checks passed) but > nothing appears to have happened since. I actually put it in next late last week, but the emails got delayed due to various gremlins. cheers