From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
benh@kernel.crashing.org, paulus@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [V4, 1/4] KVM: PPC: Use READ_ONCE when dereferencing pte_t pointer
Date: Sun, 29 Mar 2015 22:16:52 +0530 [thread overview]
Message-ID: <87384nn43n.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150328103326.7568E14016B@ozlabs.org>
Michael Ellerman <mpe@ellerman.id.au> writes:
> On Thu, 2015-26-03 at 13:13:39 UTC, "Aneesh Kumar K.V" wrote:
>> pte can get updated from other CPUs as part of multiple activities
>> like THP split, huge page collapse, unmap. We need to make sure we
>> don't reload the pte value again and again for different checks.
>>
>> ---
>> arch/powerpc/include/asm/kvm_book3s_64.h | 5 ++++-
>> arch/powerpc/kvm/e500_mmu_host.c | 20 ++++++++++++--------
>> 2 files changed, 16 insertions(+), 9 deletions(-)
>
> So this series is partly KVM but mostly powerpc.
>
> I assume you can't split it into two separate series easily?
Yes, will do. But before that I was looking for feedback from Ben or
Paul.
>
> You haven't sent it to the KVM lists or to Alex AFAICS. You'll need to do that
> for the KVM pieces at least. We can probably take it all via powerpc, but I'll
> need an ACK from Alex at least.
>
If I can get an ack from Ben, that makes it easy for the kvm list.
-aneesh
next prev parent reply other threads:[~2015-03-29 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 13:13 [PATCH V4 1/4] KVM: PPC: Use READ_ONCE when dereferencing pte_t pointer Aneesh Kumar K.V
2015-03-26 13:13 ` [PATCH V4 2/4] KVM: PPC: Remove page table walk helpers Aneesh Kumar K.V
2015-03-26 13:13 ` [PATCH V4 3/4] powerpc/mm/thp: Make page table walk safe against thp split/collapse Aneesh Kumar K.V
2015-03-26 13:13 ` [PATCH V4 4/4] powerpc/mm/thp: Return pte address if we find trans_splitting Aneesh Kumar K.V
2015-03-28 10:33 ` [V4, 1/4] KVM: PPC: Use READ_ONCE when dereferencing pte_t pointer Michael Ellerman
2015-03-29 16:46 ` Aneesh Kumar K.V [this message]
2015-03-29 23:41 ` [V4,1/4] " Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87384nn43n.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).