From: Michael Ellerman <mpe@ellerman.id.au>
To: yanjiang.jin@windriver.com, benh@kernel.crashing.org,
paulus@samba.org, oss@buserror.net
Cc: linuxppc-dev@lists.ozlabs.org, yanjiang.jin@windriver.com,
linux-kernel@vger.kernel.org, jinyanjiang@gmail.com
Subject: Re: [PATCH] powerpc: cputime: fix a compile warning
Date: Fri, 02 Dec 2016 15:15:00 +1100 [thread overview]
Message-ID: <874m2n7yrf.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1479704219-21403-1-git-send-email-yanjiang.jin@windriver.com>
yanjiang.jin@windriver.com writes:
> diff --git a/arch/powerpc/include/asm/cputime.h b/arch/powerpc/include/asm/cputime.h
> index 4f60db0..4423e97 100644
> --- a/arch/powerpc/include/asm/cputime.h
> +++ b/arch/powerpc/include/asm/cputime.h
> @@ -228,7 +228,8 @@ static inline cputime_t clock_t_to_cputime(const unsigned long clk)
> return (__force cputime_t) ct;
> }
>
> -#define cputime64_to_clock_t(ct) cputime_to_clock_t((cputime_t)(ct))
> +#define cputime64_to_clock_t(ct) \
> + (__force u64)(cputime_to_clock_t((cputime_t)(ct)))
Given the name of the function is "cputime64 to clock_t", surely we
should be returning a clock_t ?
cheers
next prev parent reply other threads:[~2016-12-02 4:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 4:56 [PATCH] powerpc: cputime: fix a compile warning yanjiang.jin
2016-11-30 14:40 ` Scott Wood
2016-12-01 5:04 ` yjin
2016-12-02 4:15 ` Michael Ellerman [this message]
2016-12-02 4:22 ` Balbir Singh
2016-12-02 4:35 ` yjin
2016-12-02 5:15 ` Pan Xinhui
2016-12-02 5:17 ` yjin
2016-12-02 19:54 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m2n7yrf.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=jinyanjiang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=yanjiang.jin@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).