From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C924FC433EF for ; Tue, 21 Jun 2022 15:04:08 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LS8tH23k4z3cdS for ; Wed, 22 Jun 2022 01:04:07 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=FUciNkU8; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=nathanl@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=FUciNkU8; dkim-atps=neutral Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LS8sT3T6Pz2xvw for ; Wed, 22 Jun 2022 01:03:25 +1000 (AEST) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25LEnxIP035992; Tue, 21 Jun 2022 15:03:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=65fMU9n67FJlwFHGvKVLEcNniLMTH8ymHIw2cwWSPTQ=; b=FUciNkU8txtAldDnRNOocWfKYe/7BqN0Ove6s7qMxRiCYCxnpDE4AuWHEX+uBNliYI85 Mqng1db7hOYAuHyCfP6CyG0DXwutTwKbE5J49cFvFT0W4Mt+sCG9AgXGreXJ1IjiX3gd FxXH0CkHytDK24M4WFsykNmLsh6lhjV3oq4llcU82sw/CKq6bK+Q3KAh8RjOVyKMZA84 9U4xAkHyQ9RRW3L8aaREkBbO6z4h34GL7xztLzimFyWAum7tiPl9E5WsGHnUvZBtI7fB TFGaMHS7xbTriLhe4dqDVyyVMTJn4S3OzQWmJ0WqdHgFRPwRB266rSE9ZZSlmSU5YQZ+ yA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gug3mgcwy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 15:03:11 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 25LEsl2h018823; Tue, 21 Jun 2022 15:03:11 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gug3mgcwk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 15:03:11 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25LEq2tb015394; Tue, 21 Jun 2022 15:03:10 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma01wdc.us.ibm.com with ESMTP id 3gs6b9cn41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 15:03:10 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25LF39k18716822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jun 2022 15:03:09 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B476C112062; Tue, 21 Jun 2022 15:03:09 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6664C112064; Tue, 21 Jun 2022 15:03:09 +0000 (GMT) Received: from localhost (unknown [9.211.80.5]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 21 Jun 2022 15:03:09 +0000 (GMT) From: Nathan Lynch To: Scott Cheloha , linux-watchdog@vger.kernel.org Subject: Re: [PATCH v2 2/4] powerpc/pseries: add FW_FEATURE_WATCHDOG flag In-Reply-To: <20220602175353.68942-3-cheloha@linux.ibm.com> References: <20220602175353.68942-1-cheloha@linux.ibm.com> <20220602175353.68942-3-cheloha@linux.ibm.com> Date: Tue, 21 Jun 2022 10:03:08 -0500 Message-ID: <877d5anjo3.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: _Gy8H3F-MhxMSkWzr3xpZX3w7RuUjPvV X-Proofpoint-GUID: nrMHRX9aQteBjaS09Bw-jc7YesFSUZUg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-21_07,2022-06-21_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206210063 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wvoigt@us.ibm.com, aik@ozlabs.ru, Scott Cheloha , vaishnavi@linux.ibm.com, npiggin@gmail.com, tzungbi@kernel.org, brking@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, linux@roeck-us.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Scott Cheloha writes: > PAPR v2.12 specifies a new optional function set, "hcall-watchdog", > for the /rtas/ibm,hypertas-functions property. The presence of this > function set indicates support for the H_WATCHDOG hypercall. > > Check for this function set and, if present, set the new > FW_FEATURE_WATCHDOG flag. > > Signed-off-by: Scott Cheloha ... > diff --git a/arch/powerpc/include/asm/firmware.h b/arch/powerpc/include/asm/firmware.h > index 8dddd34b8ecf..398e0b5e485f 100644 > --- a/arch/powerpc/include/asm/firmware.h > +++ b/arch/powerpc/include/asm/firmware.h > @@ -55,6 +55,7 @@ > #define FW_FEATURE_RPT_INVALIDATE ASM_CONST(0x0000010000000000) > #define FW_FEATURE_FORM2_AFFINITY ASM_CONST(0x0000020000000000) > #define FW_FEATURE_ENERGY_SCALE_INFO ASM_CONST(0x0000040000000000) > +#define FW_FEATURE_WATCHDOG ASM_CONST(0x0000080000000000) > > #ifndef __ASSEMBLY__ > > @@ -76,7 +77,7 @@ enum { > FW_FEATURE_DRC_INFO | FW_FEATURE_BLOCK_REMOVE | > FW_FEATURE_PAPR_SCM | FW_FEATURE_ULTRAVISOR | > FW_FEATURE_RPT_INVALIDATE | FW_FEATURE_FORM2_AFFINITY | > - FW_FEATURE_ENERGY_SCALE_INFO, > + FW_FEATURE_ENERGY_SCALE_INFO | FW_FEATURE_WATCHDOG, > FW_FEATURE_PSERIES_ALWAYS = 0, > FW_FEATURE_POWERNV_POSSIBLE = FW_FEATURE_OPAL | FW_FEATURE_ULTRAVISOR, > FW_FEATURE_POWERNV_ALWAYS = 0, > diff --git a/arch/powerpc/platforms/pseries/firmware.c b/arch/powerpc/platforms/pseries/firmware.c > index 09c119b2f623..080108d129ed 100644 > --- a/arch/powerpc/platforms/pseries/firmware.c > +++ b/arch/powerpc/platforms/pseries/firmware.c > @@ -67,6 +67,7 @@ hypertas_fw_features_table[] = { > {FW_FEATURE_PAPR_SCM, "hcall-scm"}, > {FW_FEATURE_RPT_INVALIDATE, "hcall-rpt-invalidate"}, > {FW_FEATURE_ENERGY_SCALE_INFO, "hcall-energy-scale-info"}, > + {FW_FEATURE_WATCHDOG, "hcall-watchdog"}, > }; All looks correct. Reviewed-by: Nathan Lynch