From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D85C54FC9 for ; Mon, 20 Apr 2020 02:54:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 321A320882 for ; Mon, 20 Apr 2020 02:54:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="E2wPco9G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 321A320882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 495BBJ09kWzDqdP for ; Mon, 20 Apr 2020 12:54:48 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 495B8633KBzDqLP for ; Mon, 20 Apr 2020 12:52:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=E2wPco9G; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 495B844GZzz9sSd; Mon, 20 Apr 2020 12:52:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1587351173; bh=uh9fqOT9z7bEfk7/YkplDW0UdjdPJX+o3SKRuK1QyDo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=E2wPco9GNgNC7836Nmf61nU3MCTlGlne14R9dD+hEyU/78I9P2TI0HktTFLlxxJFm HImULtkTlM1j8U2iPyXmjwATWO/EP4wtnip7hXUmYKLk9fPBIYHtDy87SY6bT4aztY 5qVAja1DcAviCvuXEwaFrlxZD47cVLaON6oSE9YzKIhygH7oHRJ+n7/jXqFDi0FZcd AzmsgaMMmFH35Akx2wv7LPYY+SRjMVmscJpSiAliDKBvg1AYFq6BVnkQsxOT+Ps4bq jYRIc+B3m2CFZx64ukRjgn9S+kBFylLDbxRAAuTwsk26eETNTTpp5+0nTVsSm39/UN W9mVJlokJXjaQ== From: Michael Ellerman To: Chris Packham , "christophe.leroy\@c-s.fr" , "paulus\@samba.org" , "benh\@kernel.crashing.org" , "oss\@buserror.net" , "tglx\@linutronix.de" Subject: Re: [PATCH v2] powerpc/setup_64: Set cache-line-size based on cache-block-size In-Reply-To: <4d84f89aa682dc78bc0d3a8df2f14b0452465da4.camel@alliedtelesis.co.nz> References: <20200325031854.7625-1-chris.packham@alliedtelesis.co.nz> <343c0e8b01ab74481e0b8dfbe588b1c84127a487.camel@alliedtelesis.co.nz> <87tv1jirlj.fsf@mpe.ellerman.id.au> <4d84f89aa682dc78bc0d3a8df2f14b0452465da4.camel@alliedtelesis.co.nz> Date: Mon, 20 Apr 2020 12:53:03 +1000 Message-ID: <877dyaj2b4.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hamish Martin , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Chris Packham writes: > On Thu, 2020-04-16 at 21:43 +1000, Michael Ellerman wrote: >> Chris Packham writes: >> > On Wed, 2020-03-25 at 16:18 +1300, Chris Packham wrote: >> > > If {i,d}-cache-block-size is set and {i,d}-cache-line-size is >> > > not, >> > > use >> > > the block-size value for both. Per the devicetree spec cache- >> > > line- >> > > size >> > > is only needed if it differs from the block size. >> > > >> > > Signed-off-by: Chris Packham >> > > --- >> > > It looks as though the bsizep = lsizep is not required per the >> > > spec >> > > but it's >> > > probably safer to retain it. >> > > >> > > Changes in v2: >> > > - Scott pointed out that u-boot should be filling in the cache >> > > properties >> > > (which it does). But it does not specify a cache-line-size >> > > because >> > > it >> > > provides a cache-block-size and the spec says you don't have to >> > > if >> > > they are >> > > the same. So the error is in the parsing not in the devicetree >> > > itself. >> > > >> > >> > Ping? This thread went kind of quiet. >> >> I replied in the other thread: >> >> >> https://lore.kernel.org/linuxppc-dev/87369xx99u.fsf@mpe.ellerman.id.au/ >> >> But then the merge window happened which is a busy time. >> > > Yeah I figured that was the case. > >> What I'd really like is a v3 that incorporates the info I wrote in >> the >> other thread and a Fixes tag. >> >> If you feel like doing that, that would be great. Otherwise I'll do >> it >> tomorrow. > > I'll rebase against Linus's tree and have a go a adding some more words > to the commit message. Thanks. cheers