From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 279E0C3A59B for ; Mon, 2 Sep 2019 04:33:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97BDE206BA for ; Mon, 2 Sep 2019 04:33:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97BDE206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46MHJv1JGWzDqHL for ; Mon, 2 Sep 2019 14:33:35 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46MGbf6qJvzDqVr for ; Mon, 2 Sep 2019 14:01:18 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 46MGbf204Zz9sDQ; Mon, 2 Sep 2019 14:01:18 +1000 (AEST) From: Michael Ellerman To: Michal Suchanek , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v7 3/6] powerpc/perf: consolidate read_user_stack_32 In-Reply-To: <87a7bntkum.fsf@mpe.ellerman.id.au> References: <87a7bntkum.fsf@mpe.ellerman.id.au> Date: Mon, 02 Sep 2019 14:01:17 +1000 Message-ID: <877e6rtkhe.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Madhavan Srinivasan , David Hildenbrand , Heiko Carstens , Paul Mackerras , Breno Leitao , Michael Neuling , Diana Craciun , Firoz Khan , Hari Bathini , Michal Suchanek , Joel Stanley , Arnd Bergmann , Nicholas Piggin , Alexander Viro , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, "Eric W. Biederman" , Andrew Donnellan , linux-fsdevel@vger.kernel.org, Andrew Morton Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Michael Ellerman writes: > Michal Suchanek writes: ... >> @@ -295,6 +279,12 @@ static inline int current_is_64bit(void) >> } >> >> #else /* CONFIG_PPC64 */ >> +static int read_user_stack_slow(void __user *ptr, void *buf, int nb) >> +{ >> + return 0; >> +} >> +#endif /* CONFIG_PPC64 */ > > Ending the PPC64 else case here, and then restarting it below with an > ifndef means we end up with two parts of the file that define 32-bit > code, with a common chunk in the middle, which I dislike. > > I'd rather you add the empty read_user_stack_slow() in the existing > #else section and then move read_user_stack_32() below the whole ifdef > PPC64/else/endif section. > > Is there some reason that doesn't work? Gah, I missed that you split the whole file later in the series. Any reason you did it in two steps rather than moving patch 6 earlier in the series? cheers