From: Nathan Lynch <nathanl@linux.ibm.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Mingming Cao <mingming.cao@ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/8] powerpc/pseries: Do not save the previous DTL mask value
Date: Mon, 13 May 2019 11:29:37 -0500 [thread overview]
Message-ID: <877eaul3m6.fsf@linux.ibm.com> (raw)
In-Reply-To: <ebdb100c89ef17605a300371b9f4d414502601d7.1557502887.git.naveen.n.rao@linux.vnet.ibm.com>
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes:
> When CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is enabled, we always initialize
> DTL enable mask to DTL_LOG_PREEMPT (0x2). There are no other places
> where the mask is changed. As such, when reading the DTL log buffer
> through debugfs, there is no need to save and restore the previous mask
> value.
>
> We don't need to save and restore the earlier mask value if
> CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is not enabled. So, remove the field
> from the structure as well.
Makes sense.
Acked-by: Nathan Lynch <nathanl@linux.ibm.com>
next prev parent reply other threads:[~2019-05-13 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 16:26 [PATCH 0/8] Provide vcpu dispatch statistics Naveen N. Rao
2019-05-10 16:26 ` [PATCH 1/8] powerpc/pseries: Use macros for referring to the DTL enable mask Naveen N. Rao
2019-05-13 14:55 ` Nathan Lynch
2019-05-10 16:26 ` [PATCH 2/8] powerpc/pseries: Do not save the previous DTL mask value Naveen N. Rao
2019-05-13 16:29 ` Nathan Lynch [this message]
2019-05-10 16:26 ` [PATCH 3/8] powerpc/pseries: Factor out DTL buffer allocation and registration routines Naveen N. Rao
2019-05-10 16:26 ` [PATCH 4/8] powerpc/pseries: Generalize hcall_vphn() Naveen N. Rao
2019-05-10 16:26 ` [PATCH 5/8] powerpc/pseries: Introduce helpers to gatekeep DTLB usage Naveen N. Rao
2019-05-10 16:26 ` [PATCH 6/8] powerpc/pseries: Provide vcpu dispatch statistics Naveen N. Rao
2019-05-10 16:26 ` [PATCH 7/8] powerpc/pseries: Protect against hogging the cpu while setting up the stats Naveen N. Rao
2019-05-10 16:26 ` [PATCH 8/8] powerpc/pseries: Add documentation for vcpudispatch_stats Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eaul3m6.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingming.cao@ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).