From: Michael Ellerman <mpe@ellerman.id.au>
To: kbuild test robot <lkp@intel.com>,
"Christopher M. Riedl" <cmr@informatik.wtf>
Cc: linuxppc-dev@ozlabs.org, kbuild-all@01.org,
Andrew Donnellan <ajd@linux.ibm.com>
Subject: Re: [PATCH v3 1/3] powerpc/spinlocks: Refactor SHARED_PROCESSOR
Date: Mon, 12 Aug 2019 22:08:12 +1000 [thread overview]
Message-ID: <878srysi1f.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <201908120917.L7bXpUsz%lkp@intel.com>
kbuild test robot <lkp@intel.com> writes:
> Hi "Christopher,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [cannot apply to v5.3-rc4 next-20190809]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Christopher-M-Riedl/Fix-oops-in-shared-processor-spinlocks/20190806-204502
> config: powerpc-powernv_defconfig (attached as .config)
> compiler: powerpc64le-linux-gcc (GCC) 7.4.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=powerpc
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/spinlock.h:89:0,
> from include/linux/seqlock.h:36,
> from include/linux/time.h:6,
> from include/linux/compat.h:10,
> from arch/powerpc/kernel/asm-offsets.c:14:
> arch/powerpc/include/asm/spinlock.h: In function 'is_shared_processor':
>>> arch/powerpc/include/asm/spinlock.h:119:34: error: 'struct paca_struct' has no member named 'lppaca_ptr'; did you mean 'slb_cache_ptr'?
> lppaca_shared_proc(local_paca->lppaca_ptr));
> ^~~~~~~~~~
> slb_cache_ptr
> make[2]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
> make[2]: Target '__build' not remade because of errors.
> make[1]: *** [prepare0] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [sub-make] Error 2
> 7 real 4 user 3 sys 110.24% cpu make prepare
>
> vim +119 arch/powerpc/include/asm/spinlock.h
>
> 110
> 111 static inline bool is_shared_processor(void)
> 112 {
> 113 /*
> 114 * LPPACA is only available on BOOK3S so guard anything LPPACA related to
> 115 * allow other platforms (which include this common header) to compile.
> 116 */
> 117 #ifdef CONFIG_PPC_BOOK3S
I think you should use PPC_PSERIES here and that will fix it.
cheers
> 118 return (IS_ENABLED(CONFIG_PPC_SPLPAR) &&
> > 119 lppaca_shared_proc(local_paca->lppaca_ptr));
> 120 #else
> 121 return false;
> 122 #endif
> 123 }
> 124
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-08-12 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 3:01 [PATCH v3 0/3] Fix oops in shared-processor spinlocks Christopher M. Riedl
2019-08-06 3:01 ` [PATCH v3 1/3] powerpc/spinlocks: Refactor SHARED_PROCESSOR Christopher M. Riedl
2019-08-12 1:52 ` kbuild test robot
2019-08-12 12:08 ` Michael Ellerman [this message]
2019-08-06 3:01 ` [PATCH v3 2/3] powerpc/spinlocks: Rename SPLPAR-only spinlocks Christopher M. Riedl
2019-08-06 3:01 ` [PATCH v3 3/3] powerpc/spinlocks: Fix oops in shared-processor spinlocks Christopher M. Riedl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878srysi1f.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=ajd@linux.ibm.com \
--cc=cmr@informatik.wtf \
--cc=kbuild-all@01.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).