From: Daniel Axtens <dja@axtens.net>
To: Zhang Zhuoyu <hellozzy1988@126.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
tglx@linutronix.de, jiang.liu@linux.intel.com,
zhangzhuoyu@cmss.chinamobile.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs()
Date: Wed, 16 Dec 2015 17:08:41 +1100 [thread overview]
Message-ID: <878u4vapsm.fsf@gamma.ozlabs.ibm.com> (raw)
In-Reply-To: <1450242896-8322-1-git-send-email-hellozzy1988@126.com>
Hi,
A couple of things.
Firstly, your two email addresses don't match:
Zhang Zhuoyu <hellozzy1988@126.com> writes:
> From: Zhang Zhuoyu <zhangzhuoyu@cmss.chinamobile.com>
These lines do seem odd! Are they causing a problem?
I'd be more comfortable removing them if I understood why they were
added. But they've been around since the beginning of git history so
that could be a bit difficult.
Instead, would it be possible to make sure this doesn't break anything
by including some test results?
Thanks,
Daniel
> Remove paradoxical and unnecessary lines before disable local interrupt.
>
> Signed-off-by: Zhang Zhuoyu <zhangzhuoyu@cmss.chinamobile.com>
> ---
> arch/powerpc/kernel/irq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
> index 290559d..03fa686 100644
> --- a/arch/powerpc/kernel/irq.c
> +++ b/arch/powerpc/kernel/irq.c
> @@ -454,8 +454,6 @@ void migrate_irqs(void)
>
> free_cpumask_var(mask);
>
> - local_irq_enable();
> - mdelay(1);
> local_irq_disable();
> }
> #endif
> --
> 1.8.3.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-12-16 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 5:14 [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() Zhang Zhuoyu
2015-12-16 6:08 ` Daniel Axtens [this message]
2015-12-16 11:31 ` Michael Ellerman
2015-12-16 11:54 ` Denis Kirjanov
2015-12-16 14:45 ` Zhang Zhuoyu
2015-12-23 2:35 ` Zhang Zhuoyu
2015-12-23 21:55 ` Denis Kirjanov
[not found] ` <CAOJe8K2AxWR+tjHhTSpk6_CUZSp+8dmnwzuZJ3s29LmLMJBytw@mail.gmail.com>
2015-12-24 7:05 ` Zhang Zhuoyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u4vapsm.fsf@gamma.ozlabs.ibm.com \
--to=dja@axtens.net \
--cc=benh@kernel.crashing.org \
--cc=hellozzy1988@126.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=zhangzhuoyu@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).