From: Daniel Axtens <dja@axtens.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] selftests: powerpc: unmark non-kernel-doc comments
Date: Fri, 26 Mar 2021 15:50:25 +1100 [thread overview]
Message-ID: <87a6qq8qni.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <20210325200820.16594-1-rdunlap@infradead.org>
Randy Dunlap <rdunlap@infradead.org> writes:
> Drop the 'beginning of kernel-doc' notation markers (/**)
> in places that are not in kernel-doc format.
This looks good to me. Arguably we don't need the comments at all, but
it doesn't seem to hurt to keep them.
checkpatch is OK with the entire file, so there's nothing else we'd
really want to clean up while you're doing cleanups.
Reviewed-by: Daniel Axtens <dja@axtens.net>
Kind regards,
Daniel
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> tools/testing/selftests/powerpc/tm/tm-trap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20210323.orig/tools/testing/selftests/powerpc/tm/tm-trap.c
> +++ linux-next-20210323/tools/testing/selftests/powerpc/tm/tm-trap.c
> @@ -66,7 +66,7 @@ void trap_signal_handler(int signo, sigi
> /* Get thread endianness: extract bit LE from MSR */
> thread_endianness = MSR_LE & ucp->uc_mcontext.gp_regs[PT_MSR];
>
> - /***
> + /*
> * Little-Endian Machine
> */
>
> @@ -126,7 +126,7 @@ void trap_signal_handler(int signo, sigi
> }
> }
>
> - /***
> + /*
> * Big-Endian Machine
> */
>
next prev parent reply other threads:[~2021-03-26 4:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 20:08 [PATCH] selftests: powerpc: unmark non-kernel-doc comments Randy Dunlap
2021-03-26 4:50 ` Daniel Axtens [this message]
2021-03-31 1:09 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6qq8qni.fsf@linkitivity.dja.id.au \
--to=dja@axtens.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).