From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC7E9C73C66 for ; Mon, 15 Jul 2019 02:28:00 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94EFE20C01 for ; Mon, 15 Jul 2019 02:28:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94EFE20C01 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45n6rZ3g6jzDqTk for ; Mon, 15 Jul 2019 12:27:58 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45n6lv5dYlzDqTq for ; Mon, 15 Jul 2019 12:23:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45n6lv2p8Bz9sP0; Mon, 15 Jul 2019 12:23:55 +1000 (AEST) From: Michael Ellerman To: Suraj Jitindar Singh , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/3] KVM: PPC: Book3S HV: Always save guest pmu for guest capable of nesting In-Reply-To: <1563156110.2145.5.camel@gmail.com> References: <20190703012022.15644-1-sjitindarsingh@gmail.com> <87lfx2egt4.fsf@concordia.ellerman.id.au> <1563156110.2145.5.camel@gmail.com> Date: Mon, 15 Jul 2019 12:23:55 +1000 Message-ID: <87blxw9gsk.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm-ppc@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Suraj Jitindar Singh writes: > On Sat, 2019-07-13 at 13:47 +1000, Michael Ellerman wrote: >> Suraj Jitindar Singh writes: ... >> > >> > Fixes: 95a6432ce903 "KVM: PPC: Book3S HV: Streamlined guest >> > entry/exit path on P9 for radix guests" >> >> I'm not clear why this and the next commit are marked as fixing the >> above commit. Wasn't it broken prior to that commit as well? > > That was the commit which introduced the entry path which we use for a > nested guest, the path on which we need to be saving and restoring the > pmu registers and so where the new code was introduced. OK, I thought that commit was an unrelated optimisation. Agree that is a good target if it is the commit that introduced the nested path. cheers