From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75635C282CB for ; Tue, 5 Feb 2019 11:28:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC0AD20821 for ; Tue, 5 Feb 2019 11:28:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC0AD20821 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43v2QH12PFzDqK6 for ; Tue, 5 Feb 2019 22:28:39 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43v2KJ6JtBzDqJ8 for ; Tue, 5 Feb 2019 22:24:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 43v2KJ4FCKz9s4V; Tue, 5 Feb 2019 22:24:20 +1100 (AEDT) From: Michael Ellerman To: Balbir Singh , Joe Lawrence Subject: Re: [PATCH 1/4] powerpc/64s: Clear on-stack exception marker upon exception return In-Reply-To: References: <20190122155724.27557-1-joe.lawrence@redhat.com> <20190122155724.27557-2-joe.lawrence@redhat.com> <20190202011455.GN26056@350D> Date: Tue, 05 Feb 2019 22:24:19 +1100 Message-ID: <87bm3qmqak.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolai Stange , Jiri Kosina , "linux-kernel@vger.kernel.org" , Torsten Duwe , Josh Poimboeuf , live-patching@vger.kernel.org, "open list:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Balbir Singh writes: > On Sat, Feb 2, 2019 at 12:14 PM Balbir Singh wrote: >> >> On Tue, Jan 22, 2019 at 10:57:21AM -0500, Joe Lawrence wrote: >> > From: Nicolai Stange >> > >> > The ppc64 specific implementation of the reliable stacktracer, >> > save_stack_trace_tsk_reliable(), bails out and reports an "unreliable >> > trace" whenever it finds an exception frame on the stack. Stack frames >> > are classified as exception frames if the STACK_FRAME_REGS_MARKER magic, >> > as written by exception prologues, is found at a particular location. >> > >> > However, as observed by Joe Lawrence, it is possible in practice that >> > non-exception stack frames can alias with prior exception frames and thus, >> > that the reliable stacktracer can find a stale STACK_FRAME_REGS_MARKER on >> > the stack. It in turn falsely reports an unreliable stacktrace and blocks >> > any live patching transition to finish. Said condition lasts until the >> > stack frame is overwritten/initialized by function call or other means. >> > >> > In principle, we could mitigate this by making the exception frame >> > classification condition in save_stack_trace_tsk_reliable() stronger: >> > in addition to testing for STACK_FRAME_REGS_MARKER, we could also take into >> > account that for all exceptions executing on the kernel stack >> > - their stack frames's backlink pointers always match what is saved >> > in their pt_regs instance's ->gpr[1] slot and that >> > - their exception frame size equals STACK_INT_FRAME_SIZE, a value >> > uncommonly large for non-exception frames. >> > >> > However, while these are currently true, relying on them would make the >> > reliable stacktrace implementation more sensitive towards future changes in >> > the exception entry code. Note that false negatives, i.e. not detecting >> > exception frames, would silently break the live patching consistency model. >> > >> > Furthermore, certain other places (diagnostic stacktraces, perf, xmon) >> > rely on STACK_FRAME_REGS_MARKER as well. >> > >> > Make the exception exit code clear the on-stack STACK_FRAME_REGS_MARKER >> > for those exceptions running on the "normal" kernel stack and returning >> > to kernelspace: because the topmost frame is ignored by the reliable stack >> > tracer anyway, returns to userspace don't need to take care of clearing >> > the marker. >> > >> > Furthermore, as I don't have the ability to test this on Book 3E or >> > 32 bits, limit the change to Book 3S and 64 bits. >> > >> > Finally, make the HAVE_RELIABLE_STACKTRACE Kconfig option depend on >> > PPC_BOOK3S_64 for documentation purposes. Before this patch, it depended >> > on PPC64 && CPU_LITTLE_ENDIAN and because CPU_LITTLE_ENDIAN implies >> > PPC_BOOK3S_64, there's no functional change here. >> > >> > Fixes: df78d3f61480 ("powerpc/livepatch: Implement reliable stack tracing for the consistency model") >> > Reported-by: Joe Lawrence >> > Signed-off-by: Nicolai Stange >> > Signed-off-by: Joe Lawrence >> > --- >> > arch/powerpc/Kconfig | 2 +- >> > arch/powerpc/kernel/entry_64.S | 7 +++++++ >> > 2 files changed, 8 insertions(+), 1 deletion(-) >> > >> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig >> > index 2890d36eb531..73bf87b1d274 100644 >> > --- a/arch/powerpc/Kconfig >> > +++ b/arch/powerpc/Kconfig >> > @@ -220,7 +220,7 @@ config PPC >> > select HAVE_PERF_USER_STACK_DUMP >> > select HAVE_RCU_TABLE_FREE if SMP >> > select HAVE_REGS_AND_STACK_ACCESS_API >> > - select HAVE_RELIABLE_STACKTRACE if PPC64 && CPU_LITTLE_ENDIAN >> > + select HAVE_RELIABLE_STACKTRACE if PPC_BOOK3S_64 && CPU_LITTLE_ENDIAN >> > select HAVE_SYSCALL_TRACEPOINTS >> > select HAVE_VIRT_CPU_ACCOUNTING >> > select HAVE_IRQ_TIME_ACCOUNTING >> > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S >> > index 435927f549c4..a2c168b395d2 100644 >> > --- a/arch/powerpc/kernel/entry_64.S >> > +++ b/arch/powerpc/kernel/entry_64.S >> > @@ -1002,6 +1002,13 @@ END_FTR_SECTION_IFSET(CPU_FTR_HAS_PPR) >> > ld r2,_NIP(r1) >> > mtspr SPRN_SRR0,r2 >> > >> > + /* >> > + * Leaving a stale exception_marker on the stack can confuse >> > + * the reliable stack unwinder later on. Clear it. >> > + */ >> > + li r2,0 >> > + std r2,STACK_FRAME_OVERHEAD-16(r1) >> > + >> >> Could you please double check, r4 is already 0 at this point >> IIUC. So the change might be a simple >> >> std r4,STACK_FRAME_OVERHEAD-16(r1) >> > > r4 is not 0, sorry for the noise Isn't it? cheers