From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C3FC433DF for ; Wed, 14 Oct 2020 11:02:30 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD48820878 for ; Wed, 14 Oct 2020 11:02:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="RL1Y2taW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD48820878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CB8dF5hQRzDqt3 for ; Wed, 14 Oct 2020 22:02:25 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CB8b551QfzDqX9 for ; Wed, 14 Oct 2020 22:00:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=RL1Y2taW; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4CB8b356QLz9sVJ; Wed, 14 Oct 2020 22:00:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1602673233; bh=Vx3JmOYtUix/SdmMkaEvbITbR/qCEr9HRT/SmzH1A8M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RL1Y2taWEspng3Tx3sZRtL/q/b+C+B+FGfvU/a3PektPx8qsHLa7cA60mXCEC6yr1 cX0U7CU2aXuFlsTpaoh+IWKDxbZ8OoJkRF4587p5L02N3RZ3eI9FF4P2tTscEXKYCj pRm4tYgRAiqXLvvbT91CdF0bjHwPZsKBJnIe5VA/JcU7YIsNvGQTFoNQtUqvM/L5Y5 NXg8+4UcMxlG8KlyEVC3OVUJV+7leN12U9ou/iBa/SAusrG35MGe/Vj1F8/VLZJUSV vy/0YQz92VFw8scGOcwHIjpB2EnundOHRMfc5aFbak1V0JiiP8jVq4PG+gWxh8uCwj g1UPOJlg4DY2Q== From: Michael Ellerman To: "Aneesh Kumar K.V" , Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras Subject: Re: [PATCH] powerpc/features: Remove CPU_FTR_NODSISRALIGN In-Reply-To: <7b1f7fdd-0256-3370-13ab-d808b9fe9b02@linux.ibm.com> References: <0346768708b69bdbfec82f6e5b0364962b9b6932.1602489812.git.christophe.leroy@csgroup.eu> <875z7ea8t7.fsf@linux.ibm.com> <87wnzuzb1x.fsf@mpe.ellerman.id.au> <7b1f7fdd-0256-3370-13ab-d808b9fe9b02@linux.ibm.com> Date: Wed, 14 Oct 2020 22:00:29 +1100 Message-ID: <87ft6hysvm.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" "Aneesh Kumar K.V" writes: > On 10/13/20 3:45 PM, Michael Ellerman wrote: >> Christophe Leroy writes: >>> Le 13/10/2020 =C3=A0 09:23, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >>>> Christophe Leroy writes: >>>> >>>>> CPU_FTR_NODSISRALIGN has not been used since >>>>> commit 31bfdb036f12 ("powerpc: Use instruction emulation >>>>> infrastructure to handle alignment faults") >>>>> >>>>> Remove it. >>>>> >>>>> Signed-off-by: Christophe Leroy >>>>> --- >>>>> arch/powerpc/include/asm/cputable.h | 22 ++++++++++------------ >>>>> arch/powerpc/kernel/dt_cpu_ftrs.c | 8 -------- >>>>> arch/powerpc/kernel/prom.c | 2 +- >>>>> 3 files changed, 11 insertions(+), 21 deletions(-) >>>>> >>>>> diff --git a/arch/powerpc/kernel/dt_cpu_ftrs.c b/arch/powerpc/kernel/= dt_cpu_ftrs.c >>>>> index 1098863e17ee..c598961d9f15 100644 >>>>> --- a/arch/powerpc/kernel/dt_cpu_ftrs.c >>>>> +++ b/arch/powerpc/kernel/dt_cpu_ftrs.c >>>>> @@ -273,13 +273,6 @@ static int __init feat_enable_idle_nap(struct dt= _cpu_feature *f) >>>>> return 1; >>>>> } >>>>>=20=20=20=20 >>>>> -static int __init feat_enable_align_dsisr(struct dt_cpu_feature *f) >>>>> -{ >>>>> - cur_cpu_spec->cpu_features &=3D ~CPU_FTR_NODSISRALIGN; >>>>> - >>>>> - return 1; >>>>> -} >>>>> - >>>>> static int __init feat_enable_idle_stop(struct dt_cpu_feature *f) >>>>> { >>>>> u64 lpcr; >>>>> @@ -641,7 +634,6 @@ static struct dt_cpu_feature_match __initdata >>>>> {"tm-suspend-hypervisor-assist", feat_enable, CPU_FTR_P9_TM_HV_AS= SIST}, >>>>> {"tm-suspend-xer-so-bug", feat_enable, CPU_FTR_P9_TM_XER_SO_BUG}, >>>>> {"idle-nap", feat_enable_idle_nap, 0}, >>>>> - {"alignment-interrupt-dsisr", feat_enable_align_dsisr, 0}, >>=20 >> Rather than removing it entirely, I'd rather we left a comment, so that >> it's obvious that we are ignoring that feature on purpose, not because >> we forget about it. >>=20 >> eg: >>=20 >> diff --git a/arch/powerpc/kernel/dt_cpu_ftrs.c b/arch/powerpc/kernel/dt_= cpu_ftrs.c >> index f204ad79b6b5..45cb7e59bd13 100644 >> --- a/arch/powerpc/kernel/dt_cpu_ftrs.c >> +++ b/arch/powerpc/kernel/dt_cpu_ftrs.c >> @@ -640,7 +640,7 @@ static struct dt_cpu_feature_match __initdata >> {"tm-suspend-hypervisor-assist", feat_enable, CPU_FTR_P9_TM_HV_ASSIST= }, >> {"tm-suspend-xer-so-bug", feat_enable, CPU_FTR_P9_TM_XER_SO_BUG}, >> {"idle-nap", feat_enable_idle_nap, 0}, >> - {"alignment-interrupt-dsisr", feat_enable_align_dsisr, 0}, >> + // "alignment-interrupt-dsisr" ignored >> {"idle-stop", feat_enable_idle_stop, 0}, >> {"machine-check-power8", feat_enable_mce_power8, 0}, >> {"performance-monitor-power8", feat_enable_pmu_power8, 0}, >>=20 > > > why not do it as > static int __init feat_enable_align_dsisr(struct dt_cpu_feature *f) > { > /* This feature should not be enabled */ > #ifdef DEBUG > WARN(1); > #endif > > return 1; > } No one will ever turn that #define on. No one will ever turn the feature on either. Even if they did, it's not a bug because the kernel doesn't use the DSISR for alignment interrupts any more. All I want is to be able to compare the list of features defined in skiboot vs the ones in Linux and see that none are missing in Linux. cheers