LinuxPPC-Dev Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the powerpc tree
@ 2020-10-08 20:58 Stephen Rothwell
  2020-10-09  4:27 ` Michael Ellerman
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2020-10-08 20:58 UTC (permalink / raw)
  To: Michael Ellerman, PowerPC
  Cc: Linux Next Mailing List, Srikar Dronamraju, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

In commit

  a2d0230b91f7 ("cpufreq: powernv: Fix frame-size-overflow in powernv_cpufreq_reboot_notifier")

Fixes tag

  Fixes: cf30af76 ("cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the powerpc tree
  2020-10-08 20:58 linux-next: Fixes tag needs some work in the powerpc tree Stephen Rothwell
@ 2020-10-09  4:27 ` Michael Ellerman
  0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2020-10-09  4:27 UTC (permalink / raw)
  To: Stephen Rothwell, PowerPC
  Cc: Linux Next Mailing List, Srikar Dronamraju, Linux Kernel Mailing List

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> In commit
>
>   a2d0230b91f7 ("cpufreq: powernv: Fix frame-size-overflow in powernv_cpufreq_reboot_notifier")
>
> Fixes tag
>
>   Fixes: cf30af76 ("cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec")

Gah.

I've changed my scripts to make this a hard error when I'm applying
patches.

cheers

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the powerpc tree
  2020-10-06 13:05 Stephen Rothwell
@ 2020-10-07  2:39 ` Michael Ellerman
  0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2020-10-07  2:39 UTC (permalink / raw)
  To: Stephen Rothwell, PowerPC
  Cc: Linux Next Mailing List, Athira Rajeev, Linux Kernel Mailing List

Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi all,
>
> In commit
>
>   3b6c3adbb2fa ("powerpc/perf: Exclude pmc5/6 from the irrelevant PMU group constraints")
>
> Fixes tag
>
>   Fixes: 7ffd948 ("powerpc/perf: factor out power8 pmu functions")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>
> Since Michael doesn't generally rebase his tree, this is more to be
> remebered for next time.

Yeah, if it was the wrong SHA I would rebase, but not just for a short
SHA.

You can avoid this in future by doing:

$ git config --add core.abbrev 12
$ git config --add pretty.fixes 'Fixes: %h ("%s")'
$ git config --add alias.showfix 'log -1 --format=fixes'

Then you can do:

$ git showfix 7ffd948
Fixes: 7ffd948fae4c ("powerpc/perf: factor out power8 pmu functions")


cheers

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the powerpc tree
@ 2020-10-06 13:05 Stephen Rothwell
  2020-10-07  2:39 ` Michael Ellerman
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2020-10-06 13:05 UTC (permalink / raw)
  To: Michael Ellerman, PowerPC
  Cc: Linux Next Mailing List, Athira Rajeev, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Hi all,

In commit

  3b6c3adbb2fa ("powerpc/perf: Exclude pmc5/6 from the irrelevant PMU group constraints")

Fixes tag

  Fixes: 7ffd948 ("powerpc/perf: factor out power8 pmu functions")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Since Michael doesn't generally rebase his tree, this is more to be
remebered for next time.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the powerpc tree
@ 2020-07-29 21:55 Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2020-07-29 21:55 UTC (permalink / raw)
  To: Michael Ellerman, PowerPC
  Cc: Athira Rajeev, Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi all,

In commit

  443359aebce0 ("powerpc/perf: Fix MMCRA_BHRB_DISABLE define for binutils < 2.28")

Fixes tag

  Fixes: 9908c826d5ed ("Add Power10 PMU feature to DT CPU features")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Just a hint for the future.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: Fixes tag needs some work in the powerpc tree
  2019-11-29 12:12 Stephen Rothwell
@ 2019-11-29 12:15 ` Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-11-29 12:15 UTC (permalink / raw)
  To: Michael Ellerman, PowerPC
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

Hi all,

hmm, that subject is completely wrong, sorry.

On Fri, 29 Nov 2019 23:12:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Commit
> 
>   6f090192f822 ("x86/efi: remove unused variables")
> 
> is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the powerpc tree
@ 2019-11-29 12:12 Stephen Rothwell
  2019-11-29 12:15 ` Stephen Rothwell
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2019-11-29 12:12 UTC (permalink / raw)
  To: Michael Ellerman, PowerPC
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

Hi all,

Commit

  6f090192f822 ("x86/efi: remove unused variables")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: Fixes tag needs some work in the powerpc tree
@ 2019-03-03 20:38 Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-03-03 20:38 UTC (permalink / raw)
  To: Michael Ellerman, PowerPC
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Nicholas Piggin


[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi all,

In commit

  bd3524feac21 ("powerpc/64s: Fix unrelocated interrupt trampoline address test")

Fixes tag

  Fixes: ccd477028a ("powerpc/64s: Fix HV NMI vs HV interrupt recoverability test")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 20:58 linux-next: Fixes tag needs some work in the powerpc tree Stephen Rothwell
2020-10-09  4:27 ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2020-10-06 13:05 Stephen Rothwell
2020-10-07  2:39 ` Michael Ellerman
2020-07-29 21:55 Stephen Rothwell
2019-11-29 12:12 Stephen Rothwell
2019-11-29 12:15 ` Stephen Rothwell
2019-03-03 20:38 Stephen Rothwell

LinuxPPC-Dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \
		linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org
	public-inbox-index linuxppc-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git