From: Michael Ellerman <mpe@ellerman.id.au>
To: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Cc: Pingfan Liu <kernelfans@gmail.com>,
Pingfan Liu <piliu@redhat.com>,
Hari Bathini <hbathini@linux.ibm.com>
Subject: Re: [RFC PATCH 4/5] powerpc/smp: Factor out assign_threads()
Date: Thu, 15 Feb 2024 00:10:22 +1100 [thread overview]
Message-ID: <87il2r6vk1.fsf@mail.lhotse> (raw)
In-Reply-To: <87frzgnyjh.fsf@kernel.org>
Aneesh Kumar K.V <aneesh.kumar@kernel.org> writes:
> Michael Ellerman <mpe@ellerman.id.au> writes:
>
> ....
>
>> +static int assign_threads(unsigned cpu, unsigned int nthreads, bool avail,
>>
>
> May be rename 'avail' to 'present'
Yeah, will do.
cheers
>> + const __be32 *hw_ids)
>> +{
>> + for (int i = 0; i < nthreads && cpu < nr_cpu_ids; i++) {
>> + __be32 hwid;
>> +
>> + hwid = be32_to_cpu(hw_ids[i]);
>> +
>> + DBG(" thread %d -> cpu %d (hard id %d)\n", i, cpu, hwid);
>> +
>> + set_cpu_present(cpu, avail);
>> + set_cpu_possible(cpu, true);
>> + cpu_to_phys_id[cpu] = hwid;
>> + cpu++;
>> + }
>> +
>
> -aneesh
next prev parent reply other threads:[~2024-02-14 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 12:01 [RFC PATCH 1/5] powerpc/smp: Adjust nr_cpu_ids to cover all threads of a core Michael Ellerman
2023-12-29 12:01 ` [RFC PATCH 2/5] powerpc/smp: Increase nr_cpu_ids to include the boot CPU Michael Ellerman
2023-12-29 12:01 ` [RFC PATCH 3/5] powerpc/smp: Lookup avail once per device tree node Michael Ellerman
2023-12-29 12:01 ` [RFC PATCH 4/5] powerpc/smp: Factor out assign_threads() Michael Ellerman
2024-01-02 4:34 ` Aneesh Kumar K.V
2024-02-14 13:10 ` Michael Ellerman [this message]
2023-12-29 12:01 ` [RFC PATCH 5/5] powerpc/smp: Remap boot CPU onto core 0 if >= nr_cpu_ids Michael Ellerman
2023-12-29 12:07 ` Michael Ellerman
2024-01-02 0:51 ` Pingfan Liu
2024-02-13 20:16 ` Wen Xiong
2024-01-02 4:46 ` Aneesh Kumar K.V
2024-02-09 15:56 ` Jiri Bohac
2024-02-14 13:12 ` Michael Ellerman
2024-02-15 13:00 ` [RFC PATCH 1/5] powerpc/smp: Adjust nr_cpu_ids to cover all threads of a core Michael Ellerman
2024-02-16 2:42 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il2r6vk1.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@kernel.org \
--cc=hbathini@linux.ibm.com \
--cc=kernelfans@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=piliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).