From: Michael Ellerman <mpe@ellerman.id.au>
To: Nathan Lynch <nathanl@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/6] powerpc/pseries: Add firmware details to dump stack arch description
Date: Fri, 30 Sep 2022 14:28:46 +1000 [thread overview]
Message-ID: <87pmfdeb9d.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <87tu4rp885.fsf@linux.ibm.com>
Nathan Lynch <nathanl@linux.ibm.com> writes:
> Michael Ellerman <mpe@ellerman.id.au> writes:
>
>> Add firmware version details to the dump stack arch description, which
>> is printed in case of an oops.
>>
>> Currently /hypervisor only exists on KVM, so if we don't find that
>> look for something that suggests we're on phyp and if so that's
>> probably a good guess. The actual content of the ibm,fw-net-version
>> seems to be a full path so is too long to add to the description.
>
> My only reservation is that ibm,fw-net-version seems to be unspecified
> and could disappear in future firmware versions.
Yeah good point.
> /ibm,powervm-partition would be the best PAPR-specified property for
> this purpose, but I don't see it on a P8/860 partition I checked,
> unfortunately. I do see it on a P9. Presumably it's present in device
> trees on PowerVM P9 systems and later, but it's probably too new to use
> for this.
I'll look for both, it's easy enough.
> /ibm,lpar-capable "indicates that the platform is capable of supporting
> logical partitioning and is only present on such systems." This one is
> present on the P8.
But conceivably qemu/KVM could provide that property, which would defeat
the purpose here which is to differentiate which actual hypervisor we're
under.
>> eg: Hardware name: ... of:'IBM,FW860.42 (SV860_138)' hv:phyp
>
> Will this info get printed during boot as well? There are many times it
> would have been useful to me when looking at logs from non-oopsed
> kernels.
No it's not. But you're right that would often be useful.
I think we can print it at the end of probe_machine().
I'll send a v2.
cheers
next prev parent reply other threads:[~2022-09-30 4:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 13:40 [PATCH 1/6] powerpc: Add ppc_md.name to dump stack arch description Michael Ellerman
2022-09-28 13:40 ` [PATCH 2/6] powerpc: Add PVR & CPU name " Michael Ellerman
2022-09-28 13:40 ` [PATCH 3/6] powerpc/64: Add logical PVR to the " Michael Ellerman
2022-09-28 13:40 ` [PATCH 4/6] powerpc: Add device-tree model to " Michael Ellerman
2022-09-28 13:40 ` [PATCH 5/6] powerpc/powernv: Add opal details " Michael Ellerman
2022-09-28 13:40 ` [PATCH 6/6] powerpc/pseries: Add firmware " Michael Ellerman
2022-09-28 20:14 ` Nathan Lynch
2022-09-30 4:28 ` Michael Ellerman [this message]
2022-09-28 20:35 ` [PATCH 1/6] powerpc: Add ppc_md.name " Nathan Lynch
-- strict thread matches above, loose matches on Subject: below --
2015-05-05 11:12 [PATCH 1/6] dump_stack: Support adding to the " Michael Ellerman
2015-05-05 11:12 ` [PATCH 6/6] powerpc/pseries: Add firmware details to " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmfdeb9d.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).