From: Daniel Axtens <dja@axtens.net>
To: Michael Ellerman <mpe@ellerman.id.au>, Marco Elver <elver@google.com>
Cc: linux-arch <linux-arch@vger.kernel.org>,
linux-s390@vger.kernel.org,
the arch/x86 maintainers <x86@kernel.org>,
linuxppc-dev@lists.ozlabs.org,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops
Date: Wed, 04 Dec 2019 10:39:44 +1100 [thread overview]
Message-ID: <87pnh5dlmn.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <87r21lef1k.fsf@mpe.ellerman.id.au>
Hi Michael,
> I only just noticed this thread as I was about to send a pull request
> for these two commits.
>
> I think I agree that test_bit() shouldn't move (yet), but I dislike that
> the documentation ends up being confusing due to this patch.
>
> So I'm inclined to append or squash in the patch below, which removes
> the new headers from the documentation. The end result is the docs look
> more or less the same, just the ordering of some of the functions
> changes. But we don't end up with test_bit() under the "Non-atomic"
> header, and then also documented in Documentation/atomic_bitops.txt.
>
> Thoughts?
That sounds good to me.
Regards,
Daniel
>
> cheers
>
>
> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> index 2caaeb55e8dd..4ac53a1363f6 100644
> --- a/Documentation/core-api/kernel-api.rst
> +++ b/Documentation/core-api/kernel-api.rst
> @@ -57,21 +57,12 @@ The Linux kernel provides more basic utility functions.
> Bit Operations
> --------------
>
> -Atomic Operations
> -~~~~~~~~~~~~~~~~~
> -
> .. kernel-doc:: include/asm-generic/bitops/instrumented-atomic.h
> :internal:
>
> -Non-atomic Operations
> -~~~~~~~~~~~~~~~~~~~~~
> -
> .. kernel-doc:: include/asm-generic/bitops/instrumented-non-atomic.h
> :internal:
>
> -Locking Operations
> -~~~~~~~~~~~~~~~~~~
> -
> .. kernel-doc:: include/asm-generic/bitops/instrumented-lock.h
> :internal:
>
prev parent reply other threads:[~2019-12-03 23:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 2:49 [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops Daniel Axtens
2019-08-20 2:49 ` [PATCH v2 2/2] powerpc: support KASAN instrumentation of bitops Daniel Axtens
2019-08-20 16:34 ` Christophe Leroy
2019-08-20 9:55 ` [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops Marco Elver
2019-08-30 5:11 ` Daniel Axtens
2019-10-28 13:56 ` Daniel Axtens
2019-11-14 20:56 ` Marco Elver
2019-11-15 13:11 ` Daniel Axtens
2019-11-20 7:42 ` Daniel Axtens
2019-11-20 8:32 ` Marco Elver
2019-12-03 13:04 ` Michael Ellerman
2019-12-03 13:36 ` Marco Elver
2019-12-03 23:39 ` Daniel Axtens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnh5dlmn.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens.net \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).