From: Nathan Lynch <nathanl@linux.ibm.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH v4 0/5] Early node associativity
Date: Thu, 17 Oct 2019 07:27:12 -0500 [thread overview]
Message-ID: <87pnivimlb.fsf@linux.ibm.com> (raw)
In-Reply-To: <87eezvjafs.fsf@linux.ibm.com>
Nathan Lynch <nathanl@linux.ibm.com> writes:
> Srikar Dronamraju <srikar@linux.vnet.ibm.com> writes:
>> Abdul reported a warning on a shared lpar.
>> "WARNING: workqueue cpumask: online intersect > possible intersect".
>> This is because per node workqueue possible mask is set very early in the
>> boot process even before the system was querying the home node
>> associativity. However per node workqueue online cpumask gets updated
>> dynamically. Hence there is a chance when per node workqueue online cpumask
>> is a superset of per node workqueue possible mask.
>
> Sorry for the delay in following up on these. The series looks good to
> me, and I've given it a little testing with LPM and DLPAR. I've also
> verified that the cpu assignments occur early as intended on an LPAR
> where that workqueue warning had been triggered.
If this is applied I think we can remove about 500 loc from numa.c. Once
splpar cpu-node assignments are done in the same sequence as with
dedicated processor mode, numa_update_cpu_topology() and related code
becomes unneeded.
Michael?
next prev parent reply other threads:[~2019-10-17 12:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 11:09 [PATCH v4 0/5] Early node associativity Srikar Dronamraju
2019-09-13 11:09 ` [PATCH v4 1/5] powerpc/vphn: Check for error from hcall_vphn Srikar Dronamraju
2019-10-02 17:51 ` Nathan Lynch
2019-09-13 11:09 ` [PATCH v4 2/5] powerpc/numa: Handle extra hcall_vphn error cases Srikar Dronamraju
2019-10-02 17:54 ` Nathan Lynch
2019-09-13 11:09 ` [PATCH v4 3/5] powerpc/numa: Use cpu node map of first sibling thread Srikar Dronamraju
2019-10-02 17:55 ` Nathan Lynch
2019-09-13 11:09 ` [PATCH v4 4/5] powerpc/numa: Early request for home node associativity Srikar Dronamraju
2019-10-02 17:56 ` Nathan Lynch
2019-09-13 11:09 ` [PATCH v4 5/5] powerpc/numa: Remove late " Srikar Dronamraju
2019-10-02 17:57 ` Nathan Lynch
2019-10-02 17:59 ` [PATCH v4 0/5] Early " Nathan Lynch
2019-10-17 12:27 ` Nathan Lynch [this message]
2019-11-15 13:37 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnivimlb.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=sathnaga@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).