From: Michael Ellerman <mpe@ellerman.id.au>
To: Qian Cai <cai@lca.pw>
Cc: linux-arch@vger.kernel.org, bvanassche@acm.org, arnd@arndb.de,
peterz@infradead.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, paulus@samba.org, Qian Cai <cai@lca.pw>,
linuxppc-dev@lists.ozlabs.org, mingo@kernel.org
Subject: Re: [PATCH v3] powerpc/lockdep: fix a false positive warning
Date: Wed, 11 Sep 2019 00:14:34 +1000 [thread overview]
Message-ID: <87pnk8z19x.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <1568039433-10176-1-git-send-email-cai@lca.pw>
Hi Qian,
Sorry I haven't replied sooner, I've been travelling.
Qian Cai <cai@lca.pw> writes:
> The commit 108c14858b9e ("locking/lockdep: Add support for dynamic
> keys") introduced a boot warning on powerpc below, because since the
> commit 2d4f567103ff ("KVM: PPC: Introduce kvm_tmp framework") adds
> kvm_tmp[] into the .bss section and then free the rest of unused spaces
> back to the page allocator.
Thanks for debugging this, but I'd like to fix it differently.
kvm_tmp has caused trouble before, with kmemleak, and it can also cause
trouble with STRICT_KERNEL_RWX, so I'd like to change how it's done,
rather than doing more hacks for it.
It should just be a page in text that we use if needed, and don't free,
which should avoid all these problems.
I'll try and get that done and posted soon.
cheers
next prev parent reply other threads:[~2019-09-10 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 14:30 [PATCH v3] powerpc/lockdep: fix a false positive warning Qian Cai
2019-09-10 14:14 ` Michael Ellerman [this message]
2019-09-15 2:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnk8z19x.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=arnd@arndb.de \
--cc=bvanassche@acm.org \
--cc=cai@lca.pw \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).