From: Michael Ellerman <mpe@ellerman.id.au>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@lists.ozlabs.org,
Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>,
Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
mikey@neuling.org
Subject: Re: [PATCH 2/2] powerpc/ptrace: Fix setting 512B aligned breakpoints with PTRACE_SET_DEBUGREG
Date: Fri, 18 May 2018 22:56:30 +1000 [thread overview]
Message-ID: <87po1txgu9.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180517053715.24011-2-mikey@neuling.org>
Michael Neuling <mikey@neuling.org> writes:
> In this change:
> e2a800beac powerpc/hw_brk: Fix off by one error when validating DAWR region end
>
> We fixed setting the DAWR end point to its max value via
> PPC_PTRACE_SETHWDEBUG. Unfortunately we broke PTRACE_SET_DEBUGREG when
> setting a 512 byte aligned breakpoint.
>
> PTRACE_SET_DEBUGREG currently sets the length of the breakpoint to
> zero (memset() in hw_breakpoint_init()). This worked with
> arch_validate_hwbkpt_settings() before the above patch was applied but
> is now broken if the breakpoint is 512byte aligned.
>
> This sets the length of the breakpoint to 8 bytes when using
> PTRACE_SET_DEBUGREG.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> Cc: stable@vger.kernel.org # 3.10+
If this is "fixing" e2a800beac then I think v3.11 is right for the
stable tag?
$ git describe --contains --long e2a800beaca1
v3.11-rc1~94^2~4
cheers
next prev parent reply other threads:[~2018-05-18 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 5:37 [PATCH 1/2] powerpc/ptrace: Fix enforcement of DAWR contraints Michael Neuling
2018-05-17 5:37 ` [PATCH 2/2] powerpc/ptrace: Fix setting 512B aligned breakpoints with PTRACE_SET_DEBUGREG Michael Neuling
2018-05-18 12:56 ` Michael Ellerman [this message]
2018-05-21 1:49 ` Michael Neuling
2018-05-21 10:01 ` [1/2] powerpc/ptrace: Fix enforcement of DAWR contraints Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po1txgu9.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=pedromfc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).