From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Set paca->data_offset = 0 for boot cpu
Date: Fri, 21 Sep 2012 14:07:15 +0530 [thread overview]
Message-ID: <87pq5f3h6s.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1348214878-32319-1-git-send-email-michael@ellerman.id.au>
Michael Ellerman <michael@ellerman.id.au> writes:
> In commit 407821a we assigned a poison value to the paca->data_offset.
>
> Unfortunately with CONFIG_LOCK_STAT=y lockdep will read & write to percpu
> data very early in boot, prior to us initialising the percpu areas,
> leading to a crash.
>
> We have been getting away with this because the data_offset was previously
> set to zero. This causes lockdep to read & write to the initial copy of
> the percpu variables, which are discarded later in boot.
>
> Although that is "fishy", it does work, and for lock statistics it is no
> big deal to discard the counts from early boot.
>
> So set the paca->data_offset = 0 for the boot cpu paca only.
>
> Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Tested-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
> arch/powerpc/kernel/setup_64.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 389bd4f..efb6a41 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -208,6 +208,8 @@ void __init early_setup(unsigned long dt_ptr)
>
> /* Fix up paca fields required for the boot cpu */
> get_paca()->cpu_start = 1;
> + /* Allow percpu accesses to "work" until we setup percpu data */
> + get_paca()->data_offset = 0;
>
> /* Probe the machine type */
> probe_machine();
> --
> 1.7.9.5
prev parent reply other threads:[~2012-09-21 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 8:07 [PATCH] powerpc: Set paca->data_offset = 0 for boot cpu Michael Ellerman
2012-09-21 8:37 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq5f3h6s.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).