From: Michael Ellerman <mpe@ellerman.id.au> To: Hari Bathini <hbathini@linux.ibm.com>, linuxppc-dev <linuxppc-dev@ozlabs.org> Cc: Ananth N Mavinakayanahalli <ananth@linux.ibm.com>, Mahesh J Salgaonkar <mahesh@linux.ibm.com>, Vasant Hegde <hegdevasant@linux.ibm.com>, Oliver <oohall@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Daniel Axtens <dja@axtens.net> Subject: Re: [PATCH v5 11/31] powernv/fadump: add fadump support on powernv Date: Tue, 03 Sep 2019 21:10:25 +1000 Message-ID: <87sgpdr5y6.fsf@mpe.ellerman.id.au> (raw) In-Reply-To: <156630272823.8896.18439144196389587229.stgit@hbathini.in.ibm.com> Hari Bathini <hbathini@linux.ibm.com> writes: > Add basic callback functions for FADump on PowerNV platform. I assume this doesn't actually work yet? Does something block it from appearing to work at runtime? > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index d8dcd88..fc4ecfe 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -566,7 +566,7 @@ config CRASH_DUMP > > config FA_DUMP > bool "Firmware-assisted dump" > - depends on PPC64 && PPC_RTAS > + depends on PPC64 && (PPC_RTAS || PPC_POWERNV) > select CRASH_CORE > select CRASH_DUMP > help > @@ -577,7 +577,8 @@ config FA_DUMP > is meant to be a kdump replacement offering robustness and > speed not possible without system firmware assistance. > > - If unsure, say "N" > + If unsure, say "y". Only special kernels like petitboot may > + need to say "N" here. > > config IRQ_ALL_CPUS > bool "Distribute interrupts on all CPUs by default" > diff --git a/arch/powerpc/kernel/fadump-common.h b/arch/powerpc/kernel/fadump-common.h > index d2c5b16..f6c52d3 100644 > --- a/arch/powerpc/kernel/fadump-common.h > +++ b/arch/powerpc/kernel/fadump-common.h > @@ -140,4 +140,13 @@ static inline int rtas_fadump_dt_scan(struct fw_dump *fadump_config, ulong node) > } > #endif > > +#ifdef CONFIG_PPC_POWERNV > +extern int opal_fadump_dt_scan(struct fw_dump *fadump_config, ulong node); > +#else > +static inline int opal_fadump_dt_scan(struct fw_dump *fadump_config, ulong node) > +{ > + return 1; > +} Extending the strange flat device tree calling convention to these functions is not ideal. It would be better I think if they just returned bool true/false for "found it" / "not found", and then early_init_dt_scan_fw_dump() can convert that into the appropriate return value. > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index f7c8073..b8061fb9 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -114,6 +114,9 @@ int __init early_init_dt_scan_fw_dump(unsigned long node, const char *uname, > if (strcmp(uname, "rtas") == 0) > return rtas_fadump_dt_scan(&fw_dump, node); > > + if (strcmp(uname, "ibm,opal") == 0) > + return opal_fadump_dt_scan(&fw_dump, node); > + ie this would become: if (strcmp(uname, "ibm,opal") == 0 && opal_fadump_dt_scan(&fw_dump, node)) return 1; > return 0; > } > > diff --git a/arch/powerpc/platforms/powernv/Makefile b/arch/powerpc/platforms/powernv/Makefile > index da2e99e..43a6e1c 100644 > --- a/arch/powerpc/platforms/powernv/Makefile > +++ b/arch/powerpc/platforms/powernv/Makefile > @@ -6,6 +6,7 @@ obj-y += opal-msglog.o opal-hmi.o opal-power.o opal-irqchip.o > obj-y += opal-kmsg.o opal-powercap.o opal-psr.o opal-sensor-groups.o > > obj-$(CONFIG_SMP) += smp.o subcore.o subcore-asm.o > +obj-$(CONFIG_FA_DUMP) += opal-fadump.o > obj-$(CONFIG_PCI) += pci.o pci-ioda.o npu-dma.o pci-ioda-tce.o > obj-$(CONFIG_CXL_BASE) += pci-cxl.o > obj-$(CONFIG_EEH) += eeh-powernv.o > diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c b/arch/powerpc/platforms/powernv/opal-fadump.c > new file mode 100644 > index 0000000..e330877 > --- /dev/null > +++ b/arch/powerpc/platforms/powernv/opal-fadump.c > @@ -0,0 +1,97 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Firmware-Assisted Dump support on POWER platform (OPAL). > + * > + * Copyright 2019, IBM Corp. > + * Author: Hari Bathini <hbathini@linux.ibm.com> > + */ > + > +#undef DEBUG No undef again please. > +#define pr_fmt(fmt) "opal fadump: " fmt > + > +#include <linux/string.h> > +#include <linux/seq_file.h> > +#include <linux/of_fdt.h> > +#include <linux/libfdt.h> > + > +#include <asm/opal.h> > + > +#include "../../kernel/fadump-common.h" > + > +static ulong opal_fadump_init_mem_struct(struct fw_dump *fadump_conf) > +{ > + return fadump_conf->reserve_dump_area_start; > +} > + > +static int opal_fadump_register(struct fw_dump *fadump_conf) > +{ > + return -EIO; > +} > + > +static int opal_fadump_unregister(struct fw_dump *fadump_conf) > +{ > + return -EIO; > +} > + > +static int opal_fadump_invalidate(struct fw_dump *fadump_conf) > +{ > + return -EIO; > +} > + > +static int __init opal_fadump_process(struct fw_dump *fadump_conf) > +{ > + return -EINVAL; > +} > + > +static void opal_fadump_region_show(struct fw_dump *fadump_conf, > + struct seq_file *m) > +{ > +} > + > +static void opal_fadump_trigger(struct fadump_crash_info_header *fdh, > + const char *msg) > +{ > + int rc; > + > + rc = opal_cec_reboot2(OPAL_REBOOT_MPIPL, msg); > + if (rc == OPAL_UNSUPPORTED) { > + pr_emerg("Reboot type %d not supported.\n", > + OPAL_REBOOT_MPIPL); > + } else if (rc == OPAL_HARDWARE) > + pr_emerg("No backend support for MPIPL!\n"); > +} > + > +static struct fadump_ops opal_fadump_ops = { > + .fadump_init_mem_struct = opal_fadump_init_mem_struct, > + .fadump_register = opal_fadump_register, > + .fadump_unregister = opal_fadump_unregister, > + .fadump_invalidate = opal_fadump_invalidate, > + .fadump_process = opal_fadump_process, > + .fadump_region_show = opal_fadump_region_show, > + .fadump_trigger = opal_fadump_trigger, > +}; > + > +int __init opal_fadump_dt_scan(struct fw_dump *fadump_conf, ulong node) > +{ > + unsigned long dn; > + > + /* > + * Check if Firmware-Assisted Dump is supported. if yes, check > + * if dump has been initiated on last reboot. > + */ > + dn = of_get_flat_dt_subnode_by_name(node, "dump"); > + if (dn == -FDT_ERR_NOTFOUND) { > + pr_debug("FADump support is missing!\n"); > + return 1; > + } > + > + if (!of_flat_dt_is_compatible(dn, "ibm,opal-dump")) { > + pr_err("Support missing for this f/w version!\n"); > + return 1; > + } > + > + fadump_conf->ops = &opal_fadump_ops; > + fadump_conf->fadump_supported = 1; > + > + return 1; > +} cheers
next prev parent reply index Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-20 12:04 [PATCH v5 00/31] Add FADump support on PowerNV platform Hari Bathini 2019-08-20 12:04 ` [PATCH v5 01/31] powerpc/fadump: move internal macros/definitions to a new header Hari Bathini 2019-09-03 11:09 ` Michael Ellerman 2019-09-03 16:05 ` Hari Bathini 2019-08-20 12:04 ` [PATCH v5 02/31] powerpc/fadump: move internal code to a new file Hari Bathini 2019-09-03 11:09 ` Michael Ellerman 2019-09-03 16:05 ` Hari Bathini 2019-09-04 9:02 ` Mahesh Jagannath Salgaonkar 2019-09-04 18:26 ` Hari Bathini 2019-08-20 12:04 ` [PATCH v5 03/31] powerpc/fadump: Improve fadump documentation Hari Bathini 2019-08-20 12:04 ` [PATCH v5 04/31] pseries/fadump: move rtas specific definitions to platform code Hari Bathini 2019-08-20 12:04 ` [PATCH v5 05/31] pseries/fadump: introduce callbacks for platform specific operations Hari Bathini 2019-09-03 11:10 ` Michael Ellerman 2019-09-03 16:06 ` Hari Bathini 2019-09-06 6:39 ` Hari Bathini 2019-08-20 12:04 ` [PATCH v5 06/31] pseries/fadump: define register/un-register callback functions Hari Bathini 2019-09-03 11:10 ` Michael Ellerman 2019-09-03 17:15 ` Hari Bathini 2019-08-20 12:04 ` [PATCH v5 07/31] powerpc/fadump: release all the memory above boot memory size Hari Bathini 2019-09-03 11:10 ` Michael Ellerman 2019-09-03 16:27 ` Hari Bathini 2019-08-20 12:05 ` [PATCH v5 08/31] pseries/fadump: move out platform specific support from generic code Hari Bathini 2019-08-20 12:05 ` [PATCH v5 09/31] powerpc/fadump: use FADump instead of fadump for how it is pronounced Hari Bathini 2019-08-20 12:05 ` [PATCH v5 10/31] opal: add MPIPL interface definitions Hari Bathini 2019-09-03 11:10 ` Michael Ellerman 2019-09-03 16:28 ` Hari Bathini 2019-09-04 11:03 ` Michael Ellerman 2019-09-04 11:05 ` Michael Ellerman 2019-08-20 12:05 ` [PATCH v5 11/31] powernv/fadump: add fadump support on powernv Hari Bathini 2019-09-03 11:10 ` Michael Ellerman [this message] 2019-09-03 16:31 ` Hari Bathini 2019-09-04 14:33 ` Hari Bathini 2019-09-05 3:11 ` Michael Ellerman 2019-08-20 12:05 ` [PATCH v5 12/31] powernv/fadump: register kernel metadata address with opal Hari Bathini 2019-09-04 11:25 ` Michael Ellerman 2019-08-20 12:05 ` [PATCH v5 13/31] powernv/fadump: reset metadata address during clean up Hari Bathini 2019-08-27 12:00 ` Hari Bathini 2019-08-20 12:05 ` [PATCH v5 14/31] powernv/fadump: define register/un-register callback functions Hari Bathini 2019-09-05 4:15 ` Michael Ellerman 2019-09-05 7:23 ` Michael Ellerman 2019-09-05 9:54 ` Hari Bathini 2019-08-20 12:05 ` [PATCH v5 15/31] powernv/fadump: support copying multiple kernel boot memory regions Hari Bathini 2019-09-04 11:30 ` Michael Ellerman 2019-09-04 20:20 ` Hari Bathini 2019-09-05 3:13 ` Michael Ellerman 2019-08-20 12:06 ` [PATCH v5 16/31] powernv/fadump: process the crashdump by exporting it as /proc/vmcore Hari Bathini 2019-09-04 11:42 ` Michael Ellerman 2019-09-04 21:01 ` Hari Bathini 2019-08-20 12:06 ` [PATCH v5 17/31] powernv/fadump: Warn before processing partial crashdump Hari Bathini 2019-09-04 11:48 ` Michael Ellerman 2019-08-20 12:06 ` [PATCH v5 18/31] powernv/fadump: handle invalidation of crashdump and re-registraion Hari Bathini 2019-08-20 12:06 ` [PATCH v5 19/31] powerpc/fadump: Update documentation about OPAL platform support Hari Bathini 2019-09-04 11:51 ` Michael Ellerman 2019-09-04 12:08 ` Oliver O'Halloran 2019-09-05 3:15 ` Michael Ellerman 2019-08-20 12:06 ` [PATCH v5 20/31] powerpc/fadump: use smaller offset while finding memory for reservation Hari Bathini 2019-09-04 11:54 ` Michael Ellerman 2019-08-20 12:06 ` [PATCH v5 21/31] powernv/fadump: process architected register state data provided by firmware Hari Bathini 2019-09-04 12:20 ` Michael Ellerman 2019-09-09 13:23 ` Hari Bathini 2019-09-09 15:33 ` Oliver O'Halloran 2019-09-10 8:48 ` Hari Bathini 2019-09-10 14:05 ` Michael Ellerman 2019-09-10 16:10 ` Hari Bathini 2019-08-20 12:06 ` [PATCH v5 22/31] powerpc/fadump: make crash memory ranges array allocation generic Hari Bathini 2019-08-20 12:06 ` [PATCH v5 23/31] powerpc/fadump: consider reserved ranges while releasing memory Hari Bathini 2019-08-20 12:07 ` [PATCH v5 24/31] powerpc/fadump: improve how crashed kernel's memory is reserved Hari Bathini 2019-08-20 12:07 ` [PATCH v5 25/31] powernv/fadump: add support to preserve crash data on FADUMP disabled kernel Hari Bathini 2019-08-20 12:07 ` [PATCH v5 26/31] powerpc/fadump: update documentation about CONFIG_PRESERVE_FA_DUMP Hari Bathini 2019-08-20 12:07 ` [PATCH v5 27/31] powernv/opalcore: export /sys/firmware/opal/core for analysing opal crashes Hari Bathini 2019-08-20 12:07 ` [PATCH v5 28/31] powernv/opalcore: provide an option to invalidate /sys/firmware/opal/core file Hari Bathini 2019-08-20 12:07 ` [PATCH v5 29/31] powerpc/fadump: consider f/w load area Hari Bathini 2019-08-20 12:07 ` [PATCH v5 30/31] powernv/fadump: update documentation about option to release opalcore Hari Bathini 2019-08-20 12:07 ` [PATCH v5 31/31] powernv/fadump: support holes in kernel boot memory area Hari Bathini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87sgpdr5y6.fsf@mpe.ellerman.id.au \ --to=mpe@ellerman.id.au \ --cc=ananth@linux.ibm.com \ --cc=dja@axtens.net \ --cc=hbathini@linux.ibm.com \ --cc=hegdevasant@linux.ibm.com \ --cc=linuxppc-dev@ozlabs.org \ --cc=mahesh@linux.ibm.com \ --cc=npiggin@gmail.com \ --cc=oohall@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LinuxPPC-Dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \ linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org public-inbox-index linuxppc-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git