From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21720C74A5B for ; Thu, 16 Mar 2023 23:59:54 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Pd44m25GNz3f4L for ; Fri, 17 Mar 2023 10:59:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=H9aXq6XW; dkim=fail reason="signature verification failed" header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vrFmJJMH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.de (client-ip=195.135.220.28; helo=smtp-out1.suse.de; envelope-from=tiwai@suse.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=H9aXq6XW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=vrFmJJMH; dkim-atps=neutral Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Pchqg0z84z3c34 for ; Thu, 16 Mar 2023 20:32:14 +1100 (AEDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E58EF21852; Thu, 16 Mar 2023 09:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678959130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgQ6KC2ybaQuhcxvNbj5yWV84Hdg07Eok3qBPbbxY94=; b=H9aXq6XWzgXy3V6gUMaMgKEQOC4u2wwCwuM31XT6epw3vcSavDTpG7v1DmpLitT3aAzvrb Uij7YtTtCMzKsnoVFyM4P36fE8radT/BVqUmJO5oz33vf5WRPcRwuHN+AiCd+tOxzXuyQp 7HO6F55yqLXCARRi8VELwLEQafIfemA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678959130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgQ6KC2ybaQuhcxvNbj5yWV84Hdg07Eok3qBPbbxY94=; b=vrFmJJMHnJyGAG4vQo3kBbAm10wkR+7Kjjsf57BxURiziFHRuM5x12k5OToJ7bvAHK8XWM BGwhhqI50dx0VBCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE806133E0; Thu, 16 Mar 2023 09:32:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9o+MNRjiEmRkRAAAMHmgww (envelope-from ); Thu, 16 Mar 2023 09:32:08 +0000 Date: Thu, 16 Mar 2023 10:32:08 +0100 Message-ID: <87ttylhwiv.wl-tiwai@suse.de> From: Takashi Iwai To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 17 Mar 2023 10:59:01 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heiko Stuebner , Xiubo Li , Moises Cardona , Jaroslav Kysela , Liam Girdwood , Muralidhar Reddy , Sylwester Nawrocki , Gongjun Song , Gaosheng Cui , Marek Szyprowski , Samuel Holland , Ranjani Sridharan , NXP Linux Team , Olivier Moysan , Martin =?ISO-8859-2?Q?Povi=B9er?= , Linus Walleij , Sascha Hauer , Nicholas Piggin , James Schulman , syed saba kareem , Thomas Gleixner , linux-omap@vger.kernel.org, Alexander Sverdlin , Allison Randal , Scott Branden , Geoff Levand , Greg Kroah-Hartman , Zhang Qilong , linux-stm32@st-md-mailman.stormreply.com, Shang XiaoJing , Masami Hiramatsu , kernel@pengutronix.de, Li Chen , Claudiu Beznea , Jarkko Nikula , Alexandre Belloni , Lucas Tanure , David Rhodes , Max Filippov , Thierry Reding , Srinivas Kandagatla , Mario Limonciello , Liang He , Ban Tao , Hezi Shahmoon , Chunyan Zhang , YueHaibing , Pierre-Louis Bossart , Minghao Chi , Jonathan Hunter , linux-rockchip@lists.infradead.org, Vijendar Mukunda , Jerome Brunet , Colin Ian King , linux-xtensa@linux-xtensa.org, Charles Keepax , Aidan MacDonald , alsa-devel@alsa-project.org, Martin Blumenstingl , Haojian Zhuang , Peter Ujfalusi , Biju Das , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong , Kai Vehmanen , Meng Tang , Banajit Goswami , Amadeusz =?ISO-8859-2?Q?S=B3awi=F1ski?= , linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, Cezary Rojewski , Dan Carpenter , Kuninori Morimoto , Sameer Pujar , Li kunyu , Miaoqian Lin , Michal Simek , linux-tegra@vger.kernel.org, Neta Zur Hershkovits , Bard Liao , Marcin Wojtas , Kunihiko Hayashi , Jernej Skrabec , Chen-Yu Tsai , Broadcom internal kernel review list , Kevin Hilman , Yang Yingliang , Orson Zhai , Codrin Ciubotariu , AngeloGioacchino Del Regno , Andrey Turkin , Arnd Bergmann , Ray Jui , Jiasheng Jiang , Richard Fitzge rald , Mark Brown , Baolin Wang , Shuming Fan , Mauro Carvalho Chehab , Mohan Kumar , Zhen Ni , Liam Girdwood , Takashi Sakamoto , Linh Phung , asahi@lists.linux.dev, Akihiko Odaki , Ricardo Ribalda , Arnaud Pouliquen , Shawn Guo , Peter Rosin , Lior Amsalem , Alexandre Torgue , Nicolas Ferre , V sujith kumar Reddy , Robert Jarzmik , Jiapeng Chong , Zhu Ning , Shengjiu Wang , Nicolas Frattaroli , Trevor Wu , Yong Zhi , Maxime Coquelin , Lad Prabhakar , Nicolin Chen , Hans de Goede , Christophe JAILLET , Fabio Estevam , Matthias Brugger , Andy Shevchenko , Peter Ujfalusi , Mikhail Rudenko , patches@opensource.cirrus.com, Takashi Iwai , Krzysztof Kozlowski , linuxppc-dev@lists.ozlabs.org, Daniel Mack Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 15 Mar 2023 16:04:52 +0100, Uwe Kleine-König wrote: > > Hello, > > this series adapts the platform drivers below sound/ to use the .remove_new() > callback. Compared to the traditional .remove() callback .remove_new() returns > no value. This is a good thing because the driver core doesn't (and cannot) > cope for errors during remove. The only effect of a non-zero return value in > .remove() is that the driver core emits a warning. The device is removed anyhow > and an early return from .remove() usually yields a resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > The first two patches simplify a driver each to return zero unconditionally, > and then all drivers are trivially converted to .remove_new(). > > There are nearly no interdependencies in this patch set---only 1 <- 11 and > 2 <- 16. So even if some individual problems are found (I don't expect that), > the other patches can (and from my POV should) still be applied. > > Best regards > Uwe > > Uwe Kleine-König (173): (snip) For the whole series, Acked-by: Takashi Iwai thanks, Takashi