From: Michael Ellerman <mpe@ellerman.id.au>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
"christophe.leroy\@c-s.fr" <christophe.leroy@c-s.fr>,
"paulus\@samba.org" <paulus@samba.org>,
"benh\@kernel.crashing.org" <benh@kernel.crashing.org>,
"oss\@buserror.net" <oss@buserror.net>,
"tglx\@linutronix.de" <tglx@linutronix.de>
Cc: Hamish Martin <Hamish.Martin@alliedtelesis.co.nz>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] powerpc/setup_64: Set cache-line-size based on cache-block-size
Date: Thu, 16 Apr 2020 21:43:04 +1000 [thread overview]
Message-ID: <87tv1jirlj.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <343c0e8b01ab74481e0b8dfbe588b1c84127a487.camel@alliedtelesis.co.nz>
Chris Packham <Chris.Packham@alliedtelesis.co.nz> writes:
> Hi All,
>
> On Wed, 2020-03-25 at 16:18 +1300, Chris Packham wrote:
>> If {i,d}-cache-block-size is set and {i,d}-cache-line-size is not,
>> use
>> the block-size value for both. Per the devicetree spec cache-line-
>> size
>> is only needed if it differs from the block size.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> ---
>> It looks as though the bsizep = lsizep is not required per the spec
>> but it's
>> probably safer to retain it.
>>
>> Changes in v2:
>> - Scott pointed out that u-boot should be filling in the cache
>> properties
>> (which it does). But it does not specify a cache-line-size because
>> it
>> provides a cache-block-size and the spec says you don't have to if
>> they are
>> the same. So the error is in the parsing not in the devicetree
>> itself.
>>
>
> Ping? This thread went kind of quiet.
I replied in the other thread:
https://lore.kernel.org/linuxppc-dev/87369xx99u.fsf@mpe.ellerman.id.au/
But then the merge window happened which is a busy time.
What I'd really like is a v3 that incorporates the info I wrote in the
other thread and a Fixes tag.
If you feel like doing that, that would be great. Otherwise I'll do it
tomorrow.
cheers
next prev parent reply other threads:[~2020-04-16 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 21:36 [PATCH] powerpc/fsl: Add cache properties for T2080/T2081 Chris Packham
2020-03-25 1:59 ` Michael Ellerman
2020-03-25 2:08 ` Scott Wood
2020-03-25 2:38 ` Chris Packham
2020-03-25 2:50 ` Chris Packham
2020-03-25 3:18 ` [PATCH v2] powerpc/setup_64: Set cache-line-size based on cache-block-size Chris Packham
2020-04-16 4:36 ` Chris Packham
2020-04-16 11:43 ` Michael Ellerman [this message]
2020-04-16 21:28 ` Chris Packham
2020-04-20 2:53 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv1jirlj.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=Hamish.Martin@alliedtelesis.co.nz \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).