From: Nathan Lynch <nathanl@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: wvoigt@us.ibm.com, linux-watchdog@vger.kernel.org, aik@ozlabs.ru,
Scott Cheloha <cheloha@linux.ibm.com>,
vaishnavi@linux.ibm.com, npiggin@gmail.com, tzungbi@kernel.org,
brking@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux@roeck-us.net
Subject: Re: [PATCH v2 1/4] powerpc/pseries: hvcall.h: add H_WATCHDOG opcode, H_NOOP return code
Date: Tue, 21 Jun 2022 17:22:14 -0500 [thread overview]
Message-ID: <87v8stmzc9.fsf@linux.ibm.com> (raw)
In-Reply-To: <20220621173155.GQ25951@gate.crashing.org>
Segher Boessenkool <segher@kernel.crashing.org> writes:
> Hi!
>
> On Tue, Jun 21, 2022 at 09:44:42AM -0500, Nathan Lynch wrote:
>> Not a problem to fix in your series, but I guess these should be
>> parenthesized i.e.
>>
>> #define H_P7 (-60)
>> #define H_P8 (-61)
>> #define H_P9 (-62)
>> #define H_NOOP (-63)
>
> Why? It does not change the semantics of any correct code. For what
> incorrect code will it make the diagnostics clearer?
Yeah never mind, I was confused.
next prev parent reply other threads:[~2022-06-21 22:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 17:53 [PATCH v2 0/4] pseries-wdt: initial support for H_WATCHDOG-based watchdog timers Scott Cheloha
2022-06-02 17:53 ` [PATCH v2 1/4] powerpc/pseries: hvcall.h: add H_WATCHDOG opcode, H_NOOP return code Scott Cheloha
2022-06-21 14:44 ` Nathan Lynch
2022-06-21 17:31 ` Segher Boessenkool
2022-06-21 22:22 ` Nathan Lynch [this message]
2022-06-02 17:53 ` [PATCH v2 2/4] powerpc/pseries: add FW_FEATURE_WATCHDOG flag Scott Cheloha
2022-06-21 15:03 ` Nathan Lynch
2022-06-02 17:53 ` [PATCH v2 3/4] powerpc/pseries: register pseries-wdt device with platform bus Scott Cheloha
2022-06-21 15:30 ` Nathan Lynch
2022-06-24 13:27 ` Michael Ellerman
2022-07-07 15:53 ` Scott Cheloha
2022-06-02 17:53 ` [PATCH v2 4/4] watchdog/pseries-wdt: initial support for H_WATCHDOG-based watchdog timers Scott Cheloha
2022-06-20 6:09 ` Alexey Kardashevskiy
2022-06-21 15:45 ` Nathan Lynch
2022-06-24 13:27 ` Michael Ellerman
2022-06-24 15:31 ` Segher Boessenkool
2022-07-08 5:51 ` Scott Cheloha
2022-06-24 13:51 ` Michael Ellerman
2022-07-07 15:53 ` Scott Cheloha
2022-06-16 1:43 ` [PATCH v2 0/4] pseries-wdt: " Daniel Henrique Barboza
2022-06-16 16:44 ` Tyrel Datwyler
2022-06-16 18:16 ` Daniel Henrique Barboza
2022-06-16 18:33 ` Daniel Henrique Barboza
2022-06-17 12:54 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8stmzc9.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=brking@linux.ibm.com \
--cc=cheloha@linux.ibm.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=tzungbi@kernel.org \
--cc=vaishnavi@linux.ibm.com \
--cc=wvoigt@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).