linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Nathan Lynch <nathanl@linux.ibm.com>
Cc: ego@linux.vnet.ibm.com, mmc@linux.vnet.ibm.com,
	linuxppc-dev@lists.ozlabs.org, julietk@linux.ibm.com
Subject: Re: [PATCH] powerpc/rtas: retry when cpu offline races with suspend/migration
Date: Tue, 02 Jul 2019 12:16:34 +1000	[thread overview]
Message-ID: <87v9wli3jx.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <87blyds8tu.fsf@linux.ibm.com>

Nathan Lynch <nathanl@linux.ibm.com> writes:
> Hi Michael,
>
> Nathan Lynch <nathanl@linux.ibm.com> writes:
>> The protocol for suspending or migrating an LPAR requires all present
>> processor threads to enter H_JOIN. So if we have threads offline, we
>> have to temporarily bring them up. This can race with administrator
>> actions such as SMT state changes. As of dfd718a2ed1f ("powerpc/rtas:
>> Fix a potential race between CPU-Offline & Migration"),
>
> snowpatch/checkpatch flagged an error in my commit message here:
>
>   ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit
>   <12+ chars of sha1> ("<title line>")' - ie: 'commit dfd718a2ed1f
>   ("powerpc/rtas: Fix a potential race between CPU-Offline &
>   Migration")'
>
> I see this is in your next-test branch though. Should I fix the commit
> message and resend?

No that's fine.

You have a Fixes tag which is formatted correctly and that's what
matters IMO.

Ideally we could control that check to not complain about it being split
across lines when there's a fixes tag as well.

cheers

  reply	other threads:[~2019-07-02  2:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  6:05 [PATCH] powerpc/rtas: retry when cpu offline races with suspend/migration Nathan Lynch
2019-06-24 16:52 ` mmc
2019-06-24 17:23   ` Nathan Lynch
2019-06-25  1:02     ` Juliet Kim
2019-06-25 18:51       ` Nathan Lynch
2019-06-26 21:40         ` Juliet Kim
2019-06-27  5:01           ` Michael Ellerman
2019-06-27 21:59             ` Juliet Kim
2019-07-01 22:12 ` Nathan Lynch
2019-07-02  2:16   ` Michael Ellerman [this message]
2019-07-03 14:27 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9wli3jx.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=ego@linux.vnet.ibm.com \
    --cc=julietk@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mmc@linux.vnet.ibm.com \
    --cc=nathanl@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).