linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Alan Modra <amodra@gmail.com>, Joel Stanley <joel@jms.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/32: Include .branch_lt in data section
Date: Thu, 15 Nov 2018 23:47:52 +1100	[thread overview]
Message-ID: <87wopetslj.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181114040045.GX29784@bubble.grove.modra.org>

Alan Modra <amodra@gmail.com> writes:

> On Wed, Nov 14, 2018 at 01:32:18PM +1030, Joel Stanley wrote:
>> When building a 32 bit powerpc kernel with Binutils 2.31.1 this warning
>> is emitted:
>> 
>>  powerpc-linux-gnu-ld: warning: orphan section `.branch_lt' from
>>  `arch/powerpc/kernel/head_44x.o' being placed in section `.branch_lt'
>> 
>> As of binutils commit 2d7ad24e8726 ("Support PLT16 relocs against local
>> symbols")[1], 32 bit targets can produce .branch_lt sections in their
>> output.
>> 
>> Include these symbols in the .data section as the ppc64 kernel does.
>> 
>> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=2d7ad24e8726ba4c45c9e67be08223a146a837ce
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Reviewed-by: Alan Modra <amodra@gmail.com>
>
> Looks fine to me.
>
>> ---
>> I wasn't sure where this should go or if the ordering matters.
>
> The usual answer is: "Look at where the section goes in the standard
> linker scripts."   But that doesn't apply here.  The section will be
> empty for a kernel build so it doesn't matter where it goes.

If it's empty why don't we just discard it?

cheers

  reply	other threads:[~2018-11-15 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14  3:02 [PATCH] powerpc/32: Include .branch_lt in data section Joel Stanley
2018-11-14  4:00 ` Alan Modra
2018-11-15 12:47   ` Michael Ellerman [this message]
2018-11-18  8:26     ` Alan Modra
2018-12-19  9:51       ` Michael Ellerman
2019-02-08 13:02 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wopetslj.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=amodra@gmail.com \
    --cc=joel@jms.id.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).